Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update doc matchers json #924
Yes examples is a great idea. Maybe the matches.md file can link through to more detailed examples…
On Thu, 25 Jul 2019, 10:08 Ferdinando Santacroce, ***@***.***> wrote: I verified the behavior running existing tests, then wrote the documentation. In general, it would be nice having some examples for every assertion, too. What do you think? ------------------------------ You can view, comment on, or merge this pull request online at: #924 Commit Summary - Fixed default on write spec failure file - Add JSON assertions to the doc File Changes - *M* doc/matchers.md <https://github.com/kotlintest/kotlintest/pull/924/files#diff-0> (7) - *M* kotlintest-core/src/main/kotlin/io/kotlintest/Project.kt <https://github.com/kotlintest/kotlintest/pull/924/files#diff-1> (2) Patch Links: - https://github.com/kotlintest/kotlintest/pull/924.patch - https://github.com/kotlintest/kotlintest/pull/924.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#924?email_source=notifications&email_token=AAFVSGS4IQYZL5AEYN7GTF3QBG6XHA5CNFSM4IG3VAC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBQGPTA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGSHDN2L643SQS3XU4TQBG6XHANCNFSM4IG3VACQ> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.