Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JUnit redeclarations #944

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@Kerooker
Copy link
Member

commented Aug 10, 2019

These declarations, although they would reduce the amount of dependencies in our artifacts, were causing issues with other libraries, such as Espresso from Android.

These classes are only used to make IntelliJ know about KT, and enable the green arrow for execution. There's no reason to keep these classes as we're not modifying them.

Fixes #927

Remove JUnit redeclarations
These declarations, although they would reduce the amount of dependencies in our artifacts, were causing issues with other libraries, such as Espresso from Android.

These classes are only used to make IntelliJ know about KT, and enable the green arrow for execution. There's no reason to keep these classes as we're not modifying them.

Fixes #927

@Kerooker Kerooker requested a review from sksamuel Aug 10, 2019

@Kerooker

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2019

@sksamuel I"m mergint this to generate a snapshot build. If you need to modify any point on this, let me know

@Kerooker Kerooker merged commit 1cf24da into master Aug 11, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Kerooker Kerooker deleted the bugfix/927-remove-junit-declarations branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.