Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Kotlintest with Kotest #991

Merged
merged 2 commits into from Sep 29, 2019

Conversation

@Kerooker
Copy link
Member

commented Sep 13, 2019

No description provided.

@Kerooker Kerooker requested a review from sksamuel Sep 13, 2019
@Kerooker

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Ok, so this is the first PR for the migration of kotlintest to kotest.

I replaced all instances of kotlintest with kotest, except for anything in the documentation.

I know it's impossible to check file by file, but I don't have a clue on what we can do to ensure this is right (A lot of replacing and refactoring done in IntelliJ)

@BorzdeG

This comment has been minimized.

Copy link

commented Sep 14, 2019

But why?

@sksamuel

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

@BorzdeG #948

@sksamuel

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

@Kerooker can you fix the conflicts?

@Kerooker

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

Sure

@Kerooker Kerooker force-pushed the feature/4.0-change-package-name branch 2 times, most recently from 64854cb to 4a036f5 Sep 17, 2019
@Kerooker

This comment has been minimized.

Copy link
Member Author

commented Sep 17, 2019

@sksamuel This is probably good to go

@sksamuel

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

More conflicts.
Once these are fixed, can you make sure there are no other oustanding PRs from other contributors (except docs) and then merge?

@Kerooker Kerooker force-pushed the feature/4.0-change-package-name branch from 4a036f5 to c005ff9 Sep 29, 2019
@Kerooker

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2019

I merged master again.
I think we'll take the risk and merge this. It's getting dangerous to merge new features all the time, as we might delete something by accident.

I checked that the latest 15 commits or so to master are all OK in this PR, so I believe it will work, but we'll have to watch if anything was lost.

@Kerooker Kerooker merged commit 5de3419 into master Sep 29, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kerooker Kerooker deleted the feature/4.0-change-package-name branch Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.