New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer group and target show-super output #13

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@modelrockettier

modelrockettier commented Nov 6, 2018

This now prints "(none)" instead of uninitialized data for disks that aren't in a disk group.

The human-readable targets are now printed instead of just a number. E.g. "none" or "Group 1 (slow)" or "Device 3 (461f2a5f-a199-4887-aed9-f2ffd0372f66)" instead of just "3" or "257".

Also fixed the usage message and getopt string for the format command (-e is already there as an alias for --error_action, -g wasn't working for --group, and there isn't a -t anymore).

Finally, removed some superfluous strdup() calls which were never being freed (in this case the strdup was unnecessary since the argv[] strings will be available as long as the program is running).

modelrockettier added some commits Nov 5, 2018

Improved the show-super group and target printing
Disks without a group no longer prints uninitialized data.

Foreground, background, and promote targets now print what they are, not just
a single number. E.g.

Foreground write target:    none
Background write target:    Group 0 (slow)
Promote target:             Device 2 (b5d2aa58-9cc5-4ff0-a7ff-407216d27d7d)

@koverstreet koverstreet merged commit 11a3c46 into koverstreet:master Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment