New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcachefs-tools format target options are broken #12

Closed
modelrockettier opened this Issue Jan 12, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@modelrockettier
Copy link
Contributor

modelrockettier commented Jan 12, 2019

The koverstreet/bcachefs-tools@0e98225 commit broke the --foreground_target, --background_target, and --promote_target arguments to bcachefs format.

Here's the simple script I used to bisect the issue:

#!/bin/bash
set -e
make -j3 clean &>/dev/null || make -j3 clean
make -j3 &>/dev/null || make -j3
rm -f test.img
truncate -s 8M test.img
out=$(./bcachefs format test.img --foreground_target=test.img --background_target=test.img --promote_target=test.img)
set +e
out=$(grep -ie foreground -e background -e promote <<<"$out")
echo "$out" # Print the targets (optional)
grep -qv 'none$' <<<"$out"
exit $?

Sample output:

$ git checkout 0e98225 # The commit which broke it
$ ./test.sh 
Foreground write target:	none
Background write target:	none
Promote target:			none
$ git checkout HEAD^ # The last working commit
$ ./test.sh 
Foreground write target:	Device 0 (b4bca271-32e5-48cb-bc43-6ac615e74f9b)
Background write target:	Device 0 (b4bca271-32e5-48cb-bc43-6ac615e74f9b)
Promote target:			Device 0 (b4bca271-32e5-48cb-bc43-6ac615e74f9b)
@koverstreet

This comment has been minimized.

Copy link
Owner

koverstreet commented Jan 13, 2019

fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment