From 94f925d79626adcb04bbd1a94ca7db4c4e17475f Mon Sep 17 00:00:00 2001 From: Stanislav Seletskiy Date: Wed, 1 May 2019 16:56:07 +0300 Subject: [PATCH 1/2] api: fix invalid json annotation --- pkg/confluence/api.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/confluence/api.go b/pkg/confluence/api.go index 2de1d6c7..1cec8ee6 100644 --- a/pkg/confluence/api.go +++ b/pkg/confluence/api.go @@ -25,7 +25,7 @@ const ( type Restriction struct { User string `json:"userName"` - Group string `json:"groupName",omitempty` + Group string `json:"groupName,omitempty"` } type API struct { From 45e96ed8648f60875126b074f32d164074258770 Mon Sep 17 00:00:00 2001 From: Stanislav Seletskiy Date: Wed, 1 May 2019 16:58:28 +0300 Subject: [PATCH 2/2] add new format headers --- README.md | 8 ++++---- pkg/mark/meta.go | 19 ++++++++++++++++--- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index fed49023..41c67caa 100644 --- a/README.md +++ b/README.md @@ -22,10 +22,10 @@ Confluence instance and update it accordingly. File in extended format should follow specification ```markdown -[]:# (X-Space: ) -[]:# (X-Parent: ) -[]:# (X-Parent: ) -[]:# (X-Title: ) +<!-- Space: <space key> --> +<!-- Parent: <parent 1> --> +<!-- Parent: <parent 2> --> +<!-- Title: <title> --> <page contents> ``` diff --git a/pkg/mark/meta.go b/pkg/mark/meta.go index b49f9b2f..8c025f20 100644 --- a/pkg/mark/meta.go +++ b/pkg/mark/meta.go @@ -43,7 +43,10 @@ type Meta struct { } func ExtractMeta(data []byte) (*Meta, error) { - headerPattern := regexp.MustCompile(`\[\]:\s*#\s*\(([^:]+):\s*(.*)\)`) + var ( + headerPatternV1 = regexp.MustCompile(`\[\]:\s*#\s*\(([^:]+):\s*(.*)\)`) + headerPatternV2 = regexp.MustCompile(`<!--\s*([^:]+):\s*(.*)\s*-->`) + ) var meta *Meta @@ -55,9 +58,19 @@ func ExtractMeta(data []byte) (*Meta, error) { return nil, err } - matches := headerPattern.FindStringSubmatch(line) + matches := headerPatternV2.FindStringSubmatch(line) if matches == nil { - break + matches = headerPatternV1.FindStringSubmatch(line) + if matches == nil { + break + } + + log.Warningf( + fmt.Errorf(`legacy header usage found: %s`, line), + "please use new header format: <!-- %s: %s -->", + matches[1], + matches[2], + ) } if meta == nil {