Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic bold/italic font detection is broken in v0.13.0 #1209

Closed
maximbaz opened this issue Dec 6, 2018 · 2 comments
Closed

Automatic bold/italic font detection is broken in v0.13.0 #1209

maximbaz opened this issue Dec 6, 2018 · 2 comments

Comments

@maximbaz
Copy link
Contributor

maximbaz commented Dec 6, 2018

It now always picks "Regular". I have nothing about fonts in my kitty.conf.

❯ kitty --debug-font-fallback
[340 01:22:48.176598] Preloaded font faces:
[340 01:22:48.176649] normal face: /home/maximbaz/.local/share/fonts/InputMonoNarrow-Regular.ttf:0
[340 01:22:48.176661] bold face: /home/maximbaz/.local/share/fonts/InputMonoNarrow-Regular.ttf:0
[340 01:22:48.176671] italic face: /home/maximbaz/.local/share/fonts/InputMonoNarrow-Regular.ttf:0
[340 01:22:48.176697] bi face: /home/maximbaz/.local/share/fonts/InputMonoNarrow-Regular.ttf:0

My monospace font is defined as following in ~/.config/fontconfig/conf.d/70-monospace.conf:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE fontconfig SYSTEM "fonts.dtd">
<fontconfig>

  <alias binding="strong">
    <family>monospace</family>
    <default><family>Input Mono Narrow</family></default>
  </alias>

</fontconfig>

Bisected it for you:

a6949df72789e3c5cdce53d764433fe67a0866e8 is the first bad commit
commit a6949df72789e3c5cdce53d764433fe67a0866e8
Author: Kovid Goyal <kovid@kovidgoyal.net>
Date:   Tue Oct 23 12:22:18 2018 +0530

    Linux: Fix match rules used as aliases in Fontconfig configuration not being respected
    
    Fixes #1085

:040000 040000 e8d6829136895525a6dd3890cf8cb29a3366885b 5f6ad777c1811742bcb41b5461f5ba108a0f9f21 M      docs
:040000 040000 084302a7f38ea74ed9e96d8c87e1b18cfd8572a3 46fe0f33ab3aa883fe5669ed2242e31bc5ebc362 M      kitty

I was about to release 0.13.0 for Arch Linux, but if you could release 0.13.1 after this fix I would really appreciate.

@kovidgoyal
Copy link
Owner

I'm going to wait a little while before releasing 0.13.1 in case there are any other regressions.

@maximbaz
Copy link
Contributor Author

maximbaz commented Dec 6, 2018

Thanks for the fast fix as usual ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants