Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting cursor text color via remote control does not work #1229

Closed
yggi49 opened this issue Dec 12, 2018 · 0 comments
Closed

Setting cursor text color via remote control does not work #1229

yggi49 opened this issue Dec 12, 2018 · 0 comments

Comments

@yggi49
Copy link

yggi49 commented Dec 12, 2018

Setting the cursor background color via a kitty @ set-colors 'cursor=...' works, but setting its text color does not.

kitty-set-cursor-text-color-bug
(Screenshot taken with kitty 0.13.1.)

However, at least something happens under the hood, as is obvious when specifying a color that does not exist:

igor@john ~ % kitty @ set-colors 'cursor_text_color=foo'
Traceback (most recent call last):
  File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/bin/../lib64/kitty/__main__.py", line 117, in <module>
    main()
  File "/usr/bin/../lib64/kitty/__main__.py", line 113, in main
    func(sys.argv[1:])
  File "/usr/bin/../lib64/kitty/__main__.py", line 22, in remote_control
    main(args)
  File "/usr/bin/../lib64/kitty/kitty/remote_control.py", line 162, in main
    payload = func(global_opts, opts, items)
  File "/usr/bin/../lib64/kitty/kitty/cmds.py", line 691, in cmd_set_colors
    colors.update(parse_config((spec.replace('=', ' '),)))
  File "/usr/bin/../lib64/kitty/kitty/config.py", line 401, in parse_config
    check_keys=check_keys
  File "/usr/bin/../lib64/kitty/kitty/conf/utils.py", line 103, in parse_config_base
    _parse(lines, type_map, special_handling, ans, all_keys)
  File "/usr/bin/../lib64/kitty/kitty/conf/utils.py", line 96, in _parse
    parse_line(line, type_map, special_handling, ans, all_keys, base_path_for_includes)
  File "/usr/bin/../lib64/kitty/kitty/conf/utils.py", line 84, in parse_line
    val = tm(val)
  File "/usr/bin/../lib64/kitty/kitty/config_data.py", line 298, in cursor_text_color
    return to_color(x)
  File "/usr/bin/../lib64/kitty/kitty/conf/utils.py", line 16, in to_color
    return as_color(x, validate=True)
  File "/usr/bin/../lib64/kitty/kitty/rgb.py", line 73, in to_color
    raise ValueError('Invalid color name: {}'.format(raw))
ValueError: Invalid color name: foo

It’s just that nothing changes visually. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant