new_tab !neighbor doesn't shift the tabs down, just swaps the existing neighbor to the end

[nerdrew]

When opening a new tab with the !neighbor setting, I expect it to shift the tab list over one instead of moving the existing neighbor to the end. Is that a bug or the expected behaviour?

Given these tabs:

tab1 (active) ┇tab2 ┇tab3

Existing behavior when adding a new tab when tab1 is active:

tab1 ┇tab4 (new tab) ┇tab3 ┇tab2

Expected behavior (at least expected by me) when adding a new tab when tab1 is active:

tab1 ┇tab4 (new tab) ┇tab2 ┇tab3

Commit to fix: nerdrew@a47a01e
I can open a PR if my expectations are correct and this is a bug.

[nerdrew]

The commit I linked above actually had 2 fixes in it. You merged one of them for creating a new tab as a neighbor. The other fix was for moving tabs. Should I re-open this one or open a new issue?

Second bug:

Given these tabs:

tab1┇tab2 ┇tab3 (active)

Existing behavior when moving tab3 to the right with move_tab_forward (so it wraps and becomes the first tab):

tab3 (active)┇tab2 ┇tab1

Expected behavior (at least expected by me) when moving tab3 to the right with move_tab_forward:

tab3 (active)┇tab1 ┇tab2

[kovidgoyal]

Oh, sorry, forgot about move_tab, now fixed.