Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.14.3 crashes when launched via AwesomeWM's default launcher #1869

Closed
ndarwincorn opened this issue Jul 30, 2019 · 3 comments
Closed

0.14.3 crashes when launched via AwesomeWM's default launcher #1869

ndarwincorn opened this issue Jul 30, 2019 · 3 comments

Comments

@ndarwincorn
Copy link

kernel: linux-zen 5.2.3
display manager: lightdm 1.30.0
window manager: awesome 4.3

When run via mod4+rkittyenter, kitty fails to start. Trace from my awesome log:

Traceback (most recent call last):
  File "/usr/bin/../lib/kitty/kitty/main.py", line 314, in main
    _main()
  File "/usr/bin/../lib/kitty/kitty/main.py", line 303, in _main
    setup_environment(opts, args)
  File "/usr/bin/../lib/kitty/kitty/main.py", line 227, in setup_environment
    shell_env = read_shell_environment(opts)
  File "/usr/bin/../lib/kitty/kitty/main.py", line 220, in read_shell_environment
    return read_shell_environment.ans
AttributeError: 'function' object has no attribute 'ans'

Launching Kitty from another terminal emulator works fine. Downgrading to 0.14.2 also works.

Let me know if you need further debugging/can't repro.

@ndarwincorn
Copy link
Author

Downstream bug, in case it's a packaging issue (wasn't immediately obvious from a skim of the 0.14.2/0.14.3 diff).

@Luflosi
Copy link
Contributor

Luflosi commented Jul 30, 2019

This looks like it's an issue in kitty.

@Luflosi
Copy link
Contributor

Luflosi commented Jul 30, 2019

Which shell are you using? And can you try running <your-shell> -l -c env and see what the exit code is and if there are any error messages?

Luflosi added a commit to Luflosi/kitty that referenced this issue Jul 30, 2019
Fixes kovidgoyal#1869.
If the shell from which the environment variables are being read exits with a non-zero exit code, kitty crashes. This commit fixes the crash by returning an empty environment in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants