Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-colors does not update background border color #1957

Closed
ismay opened this issue Sep 7, 2019 · 4 comments
Closed

set-colors does not update background border color #1957

ismay opened this issue Sep 7, 2019 · 4 comments

Comments

@ismay
Copy link

ismay commented Sep 7, 2019

When using kitty @ set-colors -all <theme.conf> all colors are updated correctly, except for the border that extends the background color (see the light gray color that surrounds the dark blue, especially at the bottom, that's the background color from the old theme):

Screenshot 2019-09-07 at 10 01 34

the colors I'm setting with the set-colors command are:

background #1b182c
foreground #cbe3e7
color0 #3b3b4f
color1 #ff5458
color2 #62d196
color3 #ffb378
color4 #65b2ff
color5 #906cff
color6 #63f2f1
color7 #a6b3cc
color8 #807b8a
color9 #ff8080
color10 #95ffa4
color11 #ffe9aa
color12 #91ddff
color13 #c991e1
color14 #aaffe4
color15 #cbe3e7
url_color #65b2ff
cursor #a6b3cc
cursor_text_color #1b182c
selection_background #cbe3e7
selection_foreground #1b182c
active_tab_background #807b8a
active_tab_foreground #cbe3e7
inactive_tab_background #807b8a
inactive_tab_foreground #a6b3cc
inactive_border_color #cbe3e7
bell_border_color #cbe3e7

When I include the same theme in my kitty.conf and restart kitty the background color is extended correctly, the visual bug only happens when using set-colors (with the exact same .conf).

@kovidgoyal
Copy link
Owner

I'm not sure what you are refering to? I see a dark gray padding color at the bottom. You mean the padding in the kitty window when the window is not an exact multiple of the cell size?

@ismay
Copy link
Author

ismay commented Sep 7, 2019

You mean the padding in the kitty window when the window is not an exact multiple of the cell size?

Yes exactly, that's retaining the old background color. To clarify:

image

I should've maybe chosen more clearly contrasting colors. Can send a better screenshot if you want, let me know.

@kovidgoyal
Copy link
Owner

That's because you have multiple windows open, in this case the
configured background color is used. switch to a layout with a single
window and you will see the color change. You can use the --configured
flag to set-colors to also change the configured colors.

kovidgoyal added a commit that referenced this issue Sep 7, 2019
…the color for the global padding, instead of the configured background color

See #1957
@ismay
Copy link
Author

ismay commented Sep 7, 2019

Ah I see, I didn't realize that. Thanks for the quick reply, and my compliments on maintaining this project so well! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants