Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifting POWER kills Kitty on macOS #1997

Closed
metayan opened this issue Sep 24, 2019 · 4 comments
Closed

Shifting POWER kills Kitty on macOS #1997

metayan opened this issue Sep 24, 2019 · 4 comments

Comments

@metayan
Copy link

metayan commented Sep 24, 2019

Using CTRL+SHIFT+POWER to lock the display, and if Kitty is the current foreground application, she's gone when the system is unlocked.
Isolated it to the SHIFT+POWER combination.
Happens with at least (SHIFT|CMD|fn)+POWER.
Has worked fine until "recently" ;) .

MacBook Pro (Retina, 15-inch, Mid 2014)
macOS HighSierra 10.13.6
kitty v0.14.5-1-g2a07b3f4 (but discovered with a version that was some commits older)


Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [0]

VM Regions Near 0:
--> 
    __TEXT                 000000010476a000-000000010476b000 [    4K] r-x/rwx SM=COW  /src/*/kitty.app/Contents/MacOS/kitty

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   glfw-cocoa.so                       0x000000010743bf3c translateKey + 76 (cocoa_window.m:349)
1   glfw-cocoa.so                       0x000000010743b627 -[GLFWContentView keyDown:] + 119 (cocoa_window.m:1051)
2   com.apple.AppKit                    0x00007fff510e543d -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 5040
3   com.apple.AppKit                    0x00007fff510e3c70 -[NSWindow(NSEventRouting) sendEvent:] + 497
4   com.apple.AppKit                    0x00007fff50f45236 -[NSApplication(NSEvent) sendEvent:] + 2462
5   com.apple.AppKit                    0x00007fff507a58b5 -[NSApplication run] + 812
6   glfw-cocoa.so                       0x000000010743582a _glfwPlatformRunMainLoop + 106 (cocoa_init.m:523)
7   glfw-cocoa.so                       0x0000000107428c2f glfwRunMainLoop + 63 (init.c:345)
8   fast_data_types.so                  0x0000000104e7903c run_main_loop + 44 (glfw.c:1158)
9   fast_data_types.so                  0x0000000104e3eb0c main_loop + 92 (child-monitor.c:963)
@Luflosi
Copy link
Contributor

Luflosi commented Sep 24, 2019

I found the bug. I'll make a PR in a couple hours.

@metayan
Copy link
Author

metayan commented Sep 24, 2019

The fix works. Kitty survives POWER. Thanks.

@Luflosi
Copy link
Contributor

Luflosi commented Sep 24, 2019

You were faster than me.
Sorry for introducing that bug in f05eefc.

@kovidgoyal
Copy link
Owner

kovidgoyal commented Sep 24, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants