Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifacts between terminal content and padding/margin space #2079

Closed
absolutelynothelix opened this issue Oct 20, 2019 · 4 comments
Closed

Comments

@absolutelynothelix
Copy link

absolutelynothelix commented Oct 20, 2019

hello, i've noticed some artifacts to appear between terminal content and padding/margin space if you display an image (kitty +kitten icat ..., originally found while playing with neofetch --kitty ...).

this issue seems to be related to background opacity, because if background is fully opaque, i can't reproduce the issue. this issue also seems to be related to window geometry, because i can reproduce it only with specific window sizes.

displaying an image with kitty +kitten icat ... then opening and closing nano, window_padding_width 12.0, background_opacity 0.8:
1571604674
displaying an image with kitty +kitten icat ... then opening and closing nano, window_padding_width 12.0, background_opacity 1.0:
1571604972

kitty config: https://hastebin.com/raw/tenageyoqe

kitty 0.14.6
compton v.7.4
both from arch linux repositories (not aur)

@absolutelynothelix
Copy link
Author

absolutelynothelix commented Oct 20, 2019

i've also noticed that during some transitions (such as window resizing) margin/padding space has either different opacity, or different color, but i guess it could be compton issue. should i create another issue here to sort it out?

@absolutelynothelix absolutelynothelix changed the title glitches on margin border artifacts between terminal content and padding/margin space Oct 20, 2019
@absolutelynothelix
Copy link
Author

absolutelynothelix commented Oct 23, 2019

initially i thought there are only vertical lines, but as you can see there is a kind of frame around the image. according to the xwininfo, the window size is 1014x911 (1010x907 w/o borders, i guess they are included) and the image size is 1400x1273. window padding is set to 12 and background opacity to 0.8. i hope you will be able to reproduce the issue with this information
123

@Luflosi
Copy link
Contributor

Luflosi commented Dec 19, 2019

@mighty9245 can you try compiling kitty from source with the patch from #2214 applied and see if that fixes your issue?

@absolutelynothelix
Copy link
Author

@Luflosi, nah, the issue is still here. i would recommend you to play with terminal window geometry (resizing it and running the test) and you'll probably see that the issue is still here even with your patch.

btw i was playing with these lines adding -1 and +1 a while ago with no luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants