Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells don't render in second window if both windows contain graphics and window is semi-transparent #2310

Closed
ctrlcctrlv opened this issue Jan 24, 2020 · 1 comment · Fixed by #2311

Comments

@ctrlcctrlv
Copy link
Sponsor Contributor

Config options different from defaults:
background_opacity    0.5
cursor_blink_interval 0.0
enable_audio_bell     False
font_family           Nimbus Mono PS
font_size             24.0
update_check_interval 24.0
visual_bell_duration  0.2

Arch Linux, 1b5daf9

Discovered while working on #163, complicates that issue as the affected code path always runs with my WIP patch.

Screenshot:
2020-01-24-141143_3840x2160_scrot

I think this happens because there's only one offscreen frame buffer (see shaders.c:157), but each window should have its own offscreen framebuffer. Maybe? Could be totally wrong about the cause.

Reproduction steps:

  1. With settings above, most important being background_opacity:
  2. Run kitty +icat /path/to/image.png
  3. Open new window in same kitty process (Ctrl+Shift+n)
  4. Run kitty +icat /path/to/image.png
  5. The cells should stop rendering in the second window as my screenshot shows
@ctrlcctrlv
Copy link
Sponsor Contributor Author

I was right about the cause and am preparing a PR as we speak.

ctrlcctrlv added a commit to ctrlcctrlv/kitty that referenced this issue Jan 24, 2020
This commit fixes graphics rendering when more than one OS window is
open, all OS windows are semi-transparent, and multiple windows contain
graphics.

This commit closes kovidgoyal#2310.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant