Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'neighboring_window' command does not work after 'nex_layout' command triggered #2377

Closed
zk4 opened this issue Feb 19, 2020 · 4 comments
Closed

Comments

@zk4
Copy link

zk4 commented Feb 19, 2020

Issue

'neighboring_window' command does not work after 'nex_layout' command triggered.

Env

kitty 0.16.0 release
Mac 10.12.6

My Config

map cmd+shift+d next_layout
map cmd+d     new_window_with_cwd
enabled_layouts Horizontal,Vertical,Grid,Tall,Stack,Fat


map ctrl+cmd+h neighboring_window left
map ctrl+cmd+l neighboring_window right
map ctrl+cmd+j neighboring_window down
map ctrl+cmd+k neighboring_window up

How to reproduce the issue

  1. Open kitty 0.16.0 kitty --listen-on unix:/tmp/mykitty --debug-keyboard
  2. Press cmd+d twice to create two window
  3. ctrl+cmd+h / j /k /l works fine.
  4. Press cmd+shift+d to change layout to the above.
    image
  5. Issue happended, ctrl+cmd+h / j /k /l won't work.

Logs

on_key_input: glfw key: 74 native_code: 0x26 action: PRESS mods: 0xa text: '' state: 0 Traceback (most recent call last):
  File "kitty/boss.py", line 540, in dispatch_special_key
  File "kitty/boss.py", line 612, in dispatch_action
  File "kitty/tabs.py", line 401, in neighboring_window
  File "kitty/layout.py", line 238, in neighbors
  File "kitty/layout.py", line 800, in neighbors_for_window
  File "kitty/layout.py", line 548, in neighbors_for_window
AttributeError: 'Grid' object has no attribute 'num_full_size_windows'
sent key to child

and kitty 0.15.1 works fine

@kovidgoyal
Copy link
Owner

Works for me. You forgot to specify what layouts you are using.

@zk4
Copy link
Author

zk4 commented Feb 19, 2020

@kovidgoyal
layout sequence:
enabled_layouts Horizontal,Vertical,Grid,Tall,Stack,Fat

@zk4
Copy link
Author

zk4 commented Feb 19, 2020

in step 5:
with kitty --listen-on unix:/tmp/mykitty --debug-keyboard
kitty 0.16.0 produce this log , meanwhile 0.15.1 does not.

on_key_input: glfw key: 74 native_code: 0x26 action: PRESS mods: 0xa text: '' state: 0 Traceback (most recent call last):
  File "kitty/boss.py", line 540, in dispatch_special_key
  File "kitty/boss.py", line 612, in dispatch_action
  File "kitty/tabs.py", line 401, in neighboring_window
  File "kitty/layout.py", line 238, in neighbors
  File "kitty/layout.py", line 800, in neighbors_for_window
  File "kitty/layout.py", line 548, in neighbors_for_window
AttributeError: 'Grid' object has no attribute 'num_full_size_windows'
sent key to child

@zk4
Copy link
Author

zk4 commented Feb 19, 2020

@kovidgoyal You are just amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants