Firacode Rendering on OSX for ligatures looks offset and not-centered.

[EvanCarroll]

This looks really weird compared to my Debian machine,

On my Debian machine, HELLO::WORLD results in the :: being tighter together without sitting on the left with a glaring space on the right.

I'm using FiraCode Nerd Font and I've tried with FiraCode Nerd Font Retina

---

$ kitty --version
kitty 0.17.3 created by Kovid Goyal

---

[116 22:39:19.097078] Preloaded font faces:
[116 22:39:19.097111] normal face: /Users/evancarroll/Library/Fonts/Fira Code Retina Nerd Font Complete.otf
[116 22:39:19.097124] bold face: /Users/evancarroll/Library/Fonts/Fira Code Retina Nerd Font Complete.otf
[116 22:39:19.097135] italic face: /Users/evancarroll/Library/Fonts/Fira Code Retina Nerd Font Complete.otf
[116 22:39:19.097145] bi face: /Users/evancarroll/Library/Fonts/Fira Code Retina Nerd Font Complete.otf

---

$ brew cask info font-firacode-nerd-font
font-firacode-nerd-font: 2.1.0
https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/FiraCode
/usr/local/Caskroom/font-firacode-nerd-font/2.1.0 (80 files, 140.5MB)
From: https://github.com/Homebrew/homebrew-cask-fonts/blob/master/Casks/font-firacode-nerd-font.rb
==> Name
FiraCode Nerd Font (Fira Code)
==> Artifacts
Fira Code Light Nerd Font Complete Mono.otf (Font)
Fira Code Medium Nerd Font Complete.otf (Font)
Fira Code Retina Nerd Font Complete.otf (Font)
Fira Code Regular Nerd Font Complete.otf (Font)
Fira Code Light Nerd Font Complete.otf (Font)
Fira Code Bold Nerd Font Complete Mono.otf (Font)
Fira Code Medium Nerd Font Complete Mono.otf (Font)
Fira Code Retina Nerd Font Complete Mono.otf (Font)
Fira Code Regular Nerd Font Complete Mono.otf (Font)
Fira Code Bold Nerd Font Complete.otf (Font)

[kovidgoyal]

First, dont use patched fonts. They are often broken. And there is no need to use them with kitty. As long as you have the nerd fonts installed, kitty will pick up and use them automatically, or you could configure it to do so with symbol_map in kitty.conf. let me know if the issue persists without using patched fonts, if so, I will take a look.

[EvanCarroll]

@kovidgoyal I tried the unpatched fonts; I believe these fonts are now unpatched (same effect). I had started with them:

[116 23:30:11.822716] Preloaded font faces:
[116 23:30:11.822748] normal face: /Users/evancarroll/Library/Fonts/FiraCode-Retina.otf
[116 23:30:11.822761] bold face: /Users/evancarroll/Library/Fonts/FiraCode-Retina.otf
[116 23:30:11.822771] italic face: /Users/evancarroll/Library/Fonts/FiraCode-Retina.otf
[116 23:30:11.822781] bi face: /Users/evancarroll/Library/Fonts/FiraCode-Retina.otf

---

$ brew search fira
==> Casks
font-fira-code ✔                         font-fira-sans
font-fira-mono                           font-firacode-nerd-font
font-fira-mono-for-powerline             font-firamono-nerd-font

---

$ brew cask info font-fira-code
font-fira-code: 3.1
https://github.com/tonsky/FiraCode
/usr/local/Caskroom/font-fira-code/3.1 (29 files, 3.8MB)
From: https://github.com/Homebrew/homebrew-cask-fonts/blob/master/Casks/font-fira-code.rb
==> Name
Fira Code
==> Artifacts
otf/FiraCode-Bold.otf (Font)
otf/FiraCode-Light.otf (Font)
otf/FiraCode-Medium.otf (Font)
otf/FiraCode-Regular.otf (Font)
otf/FiraCode-Retina.otf (Font)

[alappe]

I can confirm this issue. It was introduced with v0.17.3 and working fine with v0.17.2.

Using kitty on macOS 10.14, Fira Code Retina, v3.1

[kovidgoyal]

Then it will be because of the fix for #1457

I dont really see a good solution here. centering breaks rendering for
some glyphs and not centering breaks rendering for others and there is
no a-priori way to know which are which. I could implement some hacky
solution like tracking if the glyph is a ligature and centering in that
case on macOS.

[kovidgoyal]

Note, I have not tested the fix, I leave that to somebody that uses macOS as their primary platform.

[alappe]

Using make app in the master including your fix, I still have issues:

[kovidgoyal]

This should fix that: e803505

[alappe]

Yes it does, thank you!

[horta]

Great work!