Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag n drop files not working in macOS #2605

Closed
miuirussia opened this issue Apr 28, 2020 · 5 comments
Closed

Drag n drop files not working in macOS #2605

miuirussia opened this issue Apr 28, 2020 · 5 comments

Comments

@miuirussia
Copy link

kitty(14729,0x10b725dc0) malloc: can't allocate region
:*** mach_vm_map(size=140733193392128, flags: 60000100) failed (error code=3)
kitty(14729,0x10b725dc0) malloc: *** set a breakpoint in malloc_error_break to debug
MemoryError
@Luflosi
Copy link
Contributor

Luflosi commented Apr 28, 2020

I can confirm, I'm bisecting it now.

@Luflosi
Copy link
Contributor

Luflosi commented Apr 28, 2020

e827e6f works fine, 2458c3a doesn't compile and ab9a36f crashes. If I replace WINDOW_CALLBACK(on_drop, "sy#", mime, data, (int)sz); with WINDOW_CALLBACK(on_drop, "sy", mime, data); it works fine. on_drop() in boss.py doesn't seem to accept an argument for the length.

@kovidgoyal
Copy link
Owner

@Luflosi: I dont follow, y# means convert a const char* and a size into a python bytes object. Which is what on_drop is accepting.

@Luflosi
Copy link
Contributor

Luflosi commented Apr 29, 2020

You're right.
But what's the goto for? Probably to reset global_state.callback_os_window. But shouldn't it then also be reset when any of the three cases above are executed?

@kovidgoyal
Copy link
Owner

yeah, it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants