Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fira Code font ligatures are broken #2695

Closed
saloniamatteo opened this issue May 25, 2020 · 1 comment
Closed

Fira Code font ligatures are broken #2695

saloniamatteo opened this issue May 25, 2020 · 1 comment
Labels

Comments

@saloniamatteo
Copy link

saloniamatteo commented May 25, 2020

Describe the bug
The Fira Code font ligatures appear broken. See the image below.

To Reproduce
Steps to reproduce the behavior:

  1. Open kitty terminal

Expected behavior
The font ligatures should appear normally

Screenshots
fira

Enviroment details
OS: Arch Linux
CPU: Intel Celeron Dual-Core N2840
iGPU: Intel Atom Processor Z36xxx/Z37xxx Series Graphics & Display
Mesa version: 20.0.7
OpenGL core profile shading language version string: 4.20
OpenGL version string: 3.0 Mesa 20.0.7
Fira Code version: 4-1 (from package ttf-fira-code)

kitty --debug-config output:

kitty 0.17.4 created by Kovid Goyal
Linux arch 5.6.13.a-1-hardened #1 SMP PREEMPT Fri, 15 May 2020 15:25:34 +0000 x86_64
Arch Linux \r (\l)
LSB_VERSION=1.4
DISTRIB_ID=Arch
DISTRIB_RELEASE=rolling
DISTRIB_DESCRIPTION="Arch Linux"
Loaded config files: /home/matteo/.config/kitty/kitty.conf
[146 17:12:33.540363] Ignoring invalid font_features FiraCode-Regular
Running under: X11

Config options different from defaults:
allow_remote_control  y
background            Color(red=46, green=52, blue=64)
bold_font             Fira Code Bold
color0                Color(red=59, green=66, blue=82)
color1                Color(red=191, green=97, blue=106)
color10               Color(red=163, green=190, blue=140)
color11               Color(red=235, green=203, blue=139)
color12               Color(red=129, green=161, blue=193)
color13               Color(red=180, green=142, blue=173)
color14               Color(red=143, green=188, blue=187)
color15               Color(red=236, green=239, blue=244)
color2                Color(red=163, green=190, blue=140)
color3                Color(red=235, green=203, blue=139)
color4                Color(red=129, green=161, blue=193)
color5                Color(red=180, green=142, blue=173)
color6                Color(red=136, green=192, blue=208)
color7                Color(red=229, green=232, blue=240)
color8                Color(red=76, green=86, blue=106)
color9                Color(red=191, green=97, blue=106)
cursor                Color(red=216, green=222, blue=233)
enable_audio_bell     False
font_family           Fira Code
foreground            Color(red=216, green=222, blue=233)
initial_window_height (24, 'cells')
initial_window_width  (81, 'cells')
mouse_hide_wait       0.0
remember_window_size  False
scrollback_lines      100000
url_style             1
window_margin_width   FloatEdges(left=10.0, top=10.0, right=10.0, bottom=10.0)
Added shortcuts:
	shift+control+y KeyAction(func='new_window', args=())

Additional context
My kitty.conf can be found here
Also, the Fira Code font ligatures work fine in other apps, like Firefox.

Here's additional info from neofetch:
neofetch

@kovidgoyal
Copy link
Owner

tonsky/FiraCode#1050

kovidgoyal added a commit that referenced this issue Feb 15, 2021
…raCode and CascadiaCode.

Now such ligatures are detected based on glyph naming convention.
This removes the gap in the ligatures at cell boundaries. However, at
least in Fira Code the infinite length ligature glyphs define a negative
left side bearing. This means they overlap when drawn consecutively,
leading to unsightly bumps at the joins.

Fixes #2695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants