Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nerd font unicode to unicode search list #2972

Closed
Jake-Gillberg opened this issue Sep 17, 2020 · 6 comments
Closed

Add nerd font unicode to unicode search list #2972

Jake-Gillberg opened this issue Sep 17, 2020 · 6 comments

Comments

@Jake-Gillberg
Copy link

It would be nice to see the unicode characters I have installed (nerd font) searchable from the unicode input selector

Describe alternatives you've considered
Using the unicode vim selector (which also looks unsupported currently chrisbra/unicode.vim#39)

Additional context
Looks like there is a way to get a text list of nerd font characters: ryanoasis/nerd-fonts#448

@kovidgoyal
Copy link
Owner

Generate a text file of the form:

code point in hex symbol name

for example

eb1d right triangle

and post it here and I will take a look.

@Jake-Gillberg
Copy link
Author

@Jake-Gillberg
Copy link
Author

Thanks! <3

@Finii
Copy link

Finii commented Mar 12, 2023

There is now a glyph name list in Nerd Fonts

which reflects the latest icon additions and will also reflect the drop of the offending glyphs in the Arab and CJK blocks with the next release.

@page-down
Copy link
Contributor

@Finii
Thanks for the heads up.

I recently updated the list of symbol names in kitty to nerd fonts 2.3.3.
Since you informed about another way to get the names, I compared the data in that JSON and found some issues.

  • Missing U+E323 weather night alt rain mix. This is a completely different symbol from U+E236, but has the same name. So it is overwritten by the latter one.
  • The correct codepoint for oct device desktop is U+F4A9, not the incorrect one in JSON: U+F67C (mdi comment alert).

There are many icons in there that are similar, and I would prefer to use Unicode codepoint instead of Unicode characters in JSON to make it easier to distinguish.

@Finii
Copy link

Finii commented Mar 12, 2023

Thanks for the input!

Changed the script to include the codepoints like this (unless you have a better idea):

{
  "METADATA": {
    "website": "https://www.nerdfonts.com",
    "development-website": "https://github.com/ryanoasis/nerd-fonts",
    "version": "2.3.3",
    "date": "2023-03-12 18:51:14+00:00"
  },
  "cod-account": {
    "char": "",
    "code": "eb99"
  },
  "cod-activate_breakpoints": {
    "char": "",
    "code": "ea97"
  },

Tackling the issue over there.

Finii added a commit to ryanoasis/nerd-fonts that referenced this issue Mar 12, 2023
[why]
Just having the characters themselves as data for the name is convenient
in some cases; but sometimes the codepoint is also nice. And it
certainly improves the human interaction / check of the file.

[how]
Include the character and the codepoint in the glyph-name data. This is
a breaking change. But given that the json file is rather new I believe
we can get away with it.

Sorry for the inconvenience for all the early adaptors that already use
the old/previous format. But now we are more future proof and can add
even more data without breaking old json code.

Related:
#1140
kovidgoyal/kitty#2972
chrisbra/unicode.vim#39
#448
nvim-tree/nvim-web-devicons#192

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit to ryanoasis/nerd-fonts that referenced this issue Mar 12, 2023
[why]
Just having the characters themselves as data for the name is convenient
in some cases; but sometimes the codepoint is also nice. And it
certainly improves the human interaction / check of the file.

[how]
Include the character and the codepoint in the glyph-name data. This is
a breaking change. But given that the json file is rather new I believe
we can get away with it.

Sorry for the inconvenience for all the early adaptors that already use
the old/previous format. But now we are more future proof and can add
even more data without breaking old json code.

Related:
#1140
kovidgoyal/kitty#2972
chrisbra/unicode.vim#39
#448
nvim-tree/nvim-web-devicons#192

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
Just having the characters themselves as data for the name is convenient
in some cases; but sometimes the codepoint is also nice. And it
certainly improves the human interaction / check of the file.

[how]
Include the character and the codepoint in the glyph-name data. This is
a breaking change. But given that the json file is rather new I believe
we can get away with it.

Sorry for the inconvenience for all the early adaptors that already use
the old/previous format. But now we are more future proof and can add
even more data without breaking old json code.

Related:
ryanoasis#1140
kovidgoyal/kitty#2972
chrisbra/unicode.vim#39
ryanoasis#448
nvim-tree/nvim-web-devicons#192

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants