Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having vertical split on fat layout cause graphical bug #3258

Closed
NikoKS opened this issue Jan 23, 2021 · 3 comments
Closed

Having vertical split on fat layout cause graphical bug #3258

NikoKS opened this issue Jan 23, 2021 · 3 comments
Labels

Comments

@NikoKS
Copy link

NikoKS commented Jan 23, 2021

Describe the bug
When having a vertical split using the fat layout with 3 or more windows, the window doesn't stretch all the way down.

in this screenshot, you can see that with only 2 windows, it's working as expected:
Screen Shot 2021-01-22 at 10 38 14 PM

but when I add a third window, this happens:
Screen Shot 2021-01-22 at 10 32 04 PM

The window doesn't stretch all the way down for some reason.

Also I notice that this only happen if I have multiple tab (tab bar is visible)

To Reproduce
Steps to reproduce the behavior:

  1. create fat layout (haven't try on other layouts, but so far only notice it on fat layout)
  2. have the tab bar visible
  3. open 3 or more window

Expected behavior
windows stretch all the way to bottom and no graphical glitch visible

Environment details
OS: Mac OS Mojave

Additional context
Try to reproduce the problem with kitty --config NONE

After trying with no config as suggested, I think the problem is that kitty still thinks that there is a tab bar at the bottom even though I've set my tab bar at the top.

Screen Shot 2021-01-23 at 8 58 11 AM

@NikoKS NikoKS added the bug label Jan 23, 2021
@kovidgoyal
Copy link
Owner

It cant stretch all the way to the bottom because there is not enough space left over for a complete row. When you add a third window, there is not a double border which takes more pixels, thereby causing the leftover space to appear. See the placement_strategy option in kitty.conf.

@NikoKS
Copy link
Author

NikoKS commented Jan 24, 2021

@kovidgoyal
Changing the placement_strategy doesn't seem to work for me.
I've tried placement_strategy bottom, and pacement_strategy bottom-left. and the extra padding is still there.

also, no matter how I resize the kitty window, I can't get rid of that padding.
I really think that it's making extra space thinking that there's a tab bar at the bottom. Because the size of the padding is always around the height of the tab bar.

When you have the time, please consider looking into the matter.
Thank you for your help! Kitty is near perfect if not because of this for me.

@kovidgoyal
Copy link
Owner

OK, I will take a look at it when I have a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants