Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images displaying incorrectly #3949

Closed
economix70 opened this issue Aug 18, 2021 · 0 comments
Closed

Images displaying incorrectly #3949

economix70 opened this issue Aug 18, 2021 · 0 comments
Labels

Comments

@economix70
Copy link

Describe the bug
Some images display incorrectly using the icat function. I found an earlier bug report #3518 which is a related issue.
When viewing some photos that were taken in portrait orientation, part of the image is cut off.
I believe that this is related to the way that some devices save the geometry & orientation data in the image.
In the examples below, icat draws a 4032x1960 frame based on the geometry, then rotates the image 90deg clockwise as per the orientation, resulting in an incomplete image.

To Reproduce
Steps to reproduce the behavior:

  1. kitty +kitten icat image.jpg
  2. When using images that were taken in portrait on some devices (eg Samsung & Motorola phones) the image does not display correctly. See screenshots below for an example. The image in the first screenshot was taken from the memory card of a Samsung phone. In the exif data it has Geometry: 4032x1960+0+0 and Orientation: RightTop. The image shows correctly on all of the image viewers that I tried: sxiv, shotwell, eog.
  3. In the second screenshot the image has been modified in gimp to display correctly using icat. The exif data after modification is Geometry: 1960x4032+0+0 & Orientation: TopLeft

Screenshots
icat screenshot1
icat screenshot2

Environment details

kitty 0.23.0 (827b6598b2) created by Kovid Goyal
Linux cecilbuntu 5.11.0-31-generic #33-Ubuntu SMP Wed Aug 11 13:19:04 UTC 2021 x86_64
Ubuntu 21.04 \n \l
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=21.04
DISTRIB_CODENAME=hirsute
DISTRIB_DESCRIPTION="Ubuntu 21.04"
Running under:X11
Loaded config files:
  /home/cecilia/.config/kitty/kitty.conf

Config options different from defaults:
background_opacity    0.8
bold_font             Ubuntu Mono Bold
bold_italic_font      Ubuntu Mono Bold Italic
font_family           Ubuntu Mono
font_size             13.0
italic_font           Ubuntu Mono Italic
update_check_interval 0.0

Additional context
Try to reproduce the problem with kitty --config NONE
Same result with kitty --config NONE
Full exif data for both images:
exif.txt
Reduced file size version of original photo:
burgerlores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant