Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iosevka glyphs not properly rendered #3954

Closed
marromlam opened this issue Aug 19, 2021 · 7 comments
Closed

Iosevka glyphs not properly rendered #3954

marromlam opened this issue Aug 19, 2021 · 7 comments
Labels

Comments

@marromlam
Copy link

Describe the bug
After Iosevka was fixed to work fine with kitty I tried to start using it as my main font. Soonish I saw I have problems with some glyphs be5invis/Iosevka#1188. I honestly do not know if this is an issue with kitty shrinking glyphs, or it is in the font side.

Thanks a lot!

To Reproduce
We can see it basically printing the glyphs

printf "\U02776 " # works nicely
printf "\U1F150 " # wrong

Screenshots
Screenshot 2021-08-09 at 02 23 09

Environment details

# Iosevka font {{{

font_family      Iosevka
bold_font        Iosevka Bold
italic_font      Iosevka Italic
bold_italic_font Iosevka Bold Italic
font_features    Iosevka -calt +dlig cv93=3

adjust_line_height 2

# }}}
@marromlam marromlam added the bug label Aug 19, 2021
@kovidgoyal
Copy link
Owner

The rendering is correct. U+1f150 is single width and is supposed to be
rendered in one cell. This has nothing to do with font used. If you
didnt have Iosevka that symbol would be rendered from something like
Noto Sans CJK

@marromlam
Copy link
Author

Really? Then I don't understand why with Victor Mono is looks as the 1:

Screenshot 2021-08-19 at 18 30 47

@kovidgoyal
Copy link
Owner

Ah I didnt notice the space after the symbol. And I cannot reproduce with Iosevka, with a space it renders in two cells, using the space.

@kovidgoyal
Copy link
Owner

Ah, never mind, I think I know whats going on. Iosevka's special ligature strategy turns of the space based ligatures. So setting iosevka as the main font will break some space ligatures.

@kovidgoyal kovidgoyal reopened this Aug 19, 2021
@kovidgoyal
Copy link
Owner

Bloody pain in the ass font. I will look into adding support for space based ligatures to the iosevka ligature strategy someday when I have nothing better to do. In the meantime patches are welcome.

@marromlam
Copy link
Author

Ah, never mind, I think I know whats going on. Iosevka's special ligature strategy turns of the space based ligatures. So setting iosevka as the main font will break some space ligatures.

Makes sense to me.

Bloody pain in the ass font. I will look into adding support for space based ligatures to the iosevka ligature strategy someday when I have nothing better to do. In the meantime patches are welcome.

I think in the mean time it is better to use other font.
Thanks a lot for the prompt replies!

@kovidgoyal
Copy link
Owner

Its already fixed, see the commit that closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants