Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect active_tab_foreground when using slant tab bar style #4053

Closed
jryom opened this issue Sep 23, 2021 · 0 comments
Closed

Incorrect active_tab_foreground when using slant tab bar style #4053

jryom opened this issue Sep 23, 2021 · 0 comments
Labels

Comments

@jryom
Copy link
Sponsor

jryom commented Sep 23, 2021

Describe the bug
When tab_bar_style is set to slant, the value for inactive_tab_foreground will override what is set for active_tab_foreground so the foreground color is the same for active/inactive tabs.

To Reproduce
Steps to reproduce the behavior:

  1. Apply these settings:
    Screenshot 2021-09-23 at 10 49 49
  2. See the outcome:
    Screenshot 2021-09-23 at 10 49 44

Environment details

kitty 0.23.1 created by Kovid Goyal
Darwin Mocca.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64
ProductName:	macOS ProductVersion:	11.6 BuildVersion:	20G165
Loaded config files:
  /Users/jje/.config/kitty/kitty.conf

Config options different from defaults:
active_tab_font_style           (True, False)
adjust_line_height              1.3
allow_remote_control            y
bold_font                       Iosevka Fixed ExtraBold
bold_italic_font                Iosevka Fixed ExtraBold Italic
cursor_blink_interval           0.0
cursor_text_color               None
editor                          nvim
enable_audio_bell               False
enabled_layouts                 ['grid', 'tall:bias=70', 'fat', 'horizontal']
font_family                     Iosevka Fixed Regular
font_size                       14.0
hide_window_decorations         2
inactive_text_alpha             0.7
italic_font                     Iosevka Fixed Italic
kitty_mod                       6
macos_thicken_font              0.35
placement_strategy              top-left
scrollback_fill_enlarged_window True
scrollback_lines                10000
tab_bar_edge                    1
tab_bar_style                   slant
tab_switch_strategy             left
tab_title_template              {index}. {title}
window_padding_width            FloatEdges(left=5.0, top=5.0, right=5.0, bottom=5.0)
Added shortcuts:
	alt+ctrl++ KeyAction('change_font_size', (True, '+', 2.0))
	alt+ctrl+, KeyAction('move_tab_backward')
	alt+ctrl+- KeyAction('change_font_size', (True, '-', 2.0))
	alt+ctrl+. KeyAction('move_tab_forward')
	alt+ctrl+0 KeyAction('tenth_window')
	alt+ctrl+1 KeyAction('first_window')
	alt+ctrl+2 KeyAction('second_window')
	alt+ctrl+3 KeyAction('third_window')
	alt+ctrl+4 KeyAction('fourth_window')
	alt+ctrl+5 KeyAction('fifth_window')
	alt+ctrl+6 KeyAction('sixth_window')
	alt+ctrl+7 KeyAction('seventh_window')
	alt+ctrl+8 KeyAction('eighth_window')
	alt+ctrl+9 KeyAction('ninth_window')
	alt+ctrl+= KeyAction('change_font_size', (True, '+', 2.0))
	alt+ctrl+[ KeyAction('previous_window')
	alt+ctrl+] KeyAction('next_window')
	alt+ctrl+` KeyAction('move_window_to_top')
	alt+ctrl+a > 1 KeyAction('set_background_opacity', ('1',))
	alt+ctrl+a > d KeyAction('set_background_opacity', ('default',))
	alt+ctrl+a > l KeyAction('set_background_opacity', ('-0.1',))
	alt+ctrl+a > m KeyAction('set_background_opacity', ('+0.1',))
	alt+ctrl+b KeyAction('scroll_page_up')
	alt+ctrl+c KeyAction('new_window_with_cwd')
	alt+ctrl+d KeyAction('detach_window')
	alt+ctrl+e KeyAction('open_url_with_hints')
	alt+ctrl+f KeyAction('scroll_page_down')
	alt+ctrl+h KeyAction('previous_window')
	alt+ctrl+j KeyAction('scroll_line_down')
	alt+ctrl+k KeyAction('scroll_line_up')
	alt+ctrl+l KeyAction('next_window')
	alt+ctrl+n KeyAction('next_tab')
	alt+ctrl+o KeyAction('pass_selection_to_program')
	alt+ctrl+p KeyAction('previous_tab')
	alt+ctrl+q KeyAction('close_tab')
	alt+ctrl+r KeyAction('start_resizing_window')
	alt+ctrl+s KeyAction('show_scrollback')
	alt+ctrl+t KeyAction('new_tab_with_cwd')
	alt+ctrl+u KeyAction('kitten', ('unicode_input',))
	alt+ctrl+v KeyAction('paste_from_clipboard')
	alt+ctrl+w KeyAction('close_window')
	alt+ctrl+escape KeyAction('kitty_shell', ('window',))
	alt+ctrl+enter KeyAction('new_window')
	alt+ctrl+backspace KeyAction('change_font_size', (True, None, 0.0))
	alt+ctrl+delete KeyAction('clear_terminal', ('reset', True))
	alt+ctrl+left KeyAction('move_tab_backward')
	alt+ctrl+right KeyAction('move_tab_forward')
	alt+ctrl+up KeyAction('scroll_line_up')
	alt+ctrl+down KeyAction('scroll_line_down')
	alt+ctrl+page_up KeyAction('scroll_page_up')
	alt+ctrl+page_down KeyAction('scroll_page_down')
	alt+ctrl+home KeyAction('scroll_home')
	alt+ctrl+end KeyAction('scroll_end')
	alt+ctrl+f2 KeyAction('edit_config_file')
	alt+ctrl+f5 KeyAction('load_config_file')
	alt+ctrl+f6 KeyAction('debug_config')
	alt+ctrl+f10 KeyAction('toggle_maximized')
	alt+ctrl+f11 KeyAction('toggle_fullscreen')
	alt+ctrl+kp_subtract KeyAction('change_font_size', (True, '-', 2.0))
	alt+ctrl+kp_add KeyAction('change_font_size', (True, '+', 2.0))
	cmd+k KeyAction('clear_terminal', ('reset', True))
	cmd+l KeyAction('next_layout')
	cmd+x KeyAction('change_font_size', (False, '-', 1.0))
	cmd+z KeyAction('change_font_size', (False, '+', 1.0))
	cmd+left KeyAction('move_window_backward')
	cmd+right KeyAction('move_window_forward')
Removed shortcuts:
	shift+ctrl++ KeyAction('change_font_size', (True, '+', 2.0))
	shift+ctrl+, KeyAction('move_tab_backward')
	shift+ctrl+- KeyAction('change_font_size', (True, '-', 2.0))
	shift+ctrl+. KeyAction('move_tab_forward')
	shift+ctrl+0 KeyAction('tenth_window')
	shift+ctrl+1 KeyAction('first_window')
	shift+ctrl+2 KeyAction('second_window')
	shift+ctrl+3 KeyAction('third_window')
	shift+ctrl+4 KeyAction('fourth_window')
	shift+ctrl+5 KeyAction('fifth_window')
	shift+ctrl+6 KeyAction('sixth_window')
	shift+ctrl+7 KeyAction('seventh_window')
	shift+ctrl+8 KeyAction('eighth_window')
	shift+ctrl+9 KeyAction('ninth_window')
	shift+ctrl+= KeyAction('change_font_size', (True, '+', 2.0))
	shift+ctrl+[ KeyAction('previous_window')
	shift+ctrl+] KeyAction('next_window')
	shift+ctrl+` KeyAction('move_window_to_top')
	shift+ctrl+a > 1 KeyAction('set_background_opacity', ('1',))
	shift+ctrl+a > d KeyAction('set_background_opacity', ('default',))
	shift+ctrl+a > l KeyAction('set_background_opacity', ('-0.1',))
	shift+ctrl+a > m KeyAction('set_background_opacity', ('+0.1',))
	shift+ctrl+b KeyAction('move_window_backward')
	shift+ctrl+c KeyAction('copy_to_clipboard')
	shift+ctrl+e KeyAction('open_url_with_hints')
	shift+ctrl+f KeyAction('move_window_forward')
	shift+ctrl+h KeyAction('show_scrollback')
	shift+ctrl+j KeyAction('scroll_line_down')
	shift+ctrl+k KeyAction('scroll_line_up')
	shift+ctrl+l KeyAction('next_layout')
	shift+ctrl+n KeyAction('new_os_window')
	shift+ctrl+o KeyAction('pass_selection_to_program')
	shift+ctrl+p > f KeyAction('kitten', ('hints', '--type path --program -'))
	shift+ctrl+p > h KeyAction('kitten', ('hints', '--type hash --program -'))
	shift+ctrl+p > l KeyAction('kitten', ('hints', '--type line --program -'))
	shift+ctrl+p > n KeyAction('kitten', ('hints', '--type linenum'))
	shift+ctrl+p > w KeyAction('kitten', ('hints', '--type word --program -'))
	shift+ctrl+p > y KeyAction('kitten', ('hints', '--type hyperlink'))
	shift+ctrl+p > shift+f KeyAction('kitten', ('hints', '--type path'))
	shift+ctrl+q KeyAction('close_tab')
	shift+ctrl+r KeyAction('start_resizing_window')
	shift+ctrl+s KeyAction('paste_from_selection')
	shift+ctrl+t KeyAction('new_tab')
	shift+ctrl+u KeyAction('kitten', ('unicode_input',))
	shift+ctrl+v KeyAction('paste_from_clipboard')
	shift+ctrl+w KeyAction('close_window')
	shift+ctrl+escape KeyAction('kitty_shell', ('window',))
	shift+ctrl+enter KeyAction('new_window')
	shift+ctrl+backspace KeyAction('change_font_size', (True, None, 0.0))
	shift+ctrl+delete KeyAction('clear_terminal', ('reset', True))
	shift+ctrl+left KeyAction('previous_tab')
	shift+ctrl+right KeyAction('next_tab')
	shift+ctrl+up KeyAction('scroll_line_up')
	shift+ctrl+down KeyAction('scroll_line_down')
	shift+ctrl+page_up KeyAction('scroll_page_up')
	shift+ctrl+page_down KeyAction('scroll_page_down')
	shift+ctrl+home KeyAction('scroll_home')
	shift+ctrl+end KeyAction('scroll_end')
	shift+ctrl+f2 KeyAction('edit_config_file')
	shift+ctrl+f5 KeyAction('load_config_file')
	shift+ctrl+f6 KeyAction('debug_config')
	shift+ctrl+f10 KeyAction('toggle_maximized')
	shift+ctrl+f11 KeyAction('toggle_fullscreen')
	shift+ctrl+kp_subtract KeyAction('change_font_size', (True, '-', 2.0))
	shift+ctrl+kp_add KeyAction('change_font_size', (True, '+', 2.0))
	shift+alt+ctrl+t KeyAction('set_tab_title')
Changed shortcuts:
	cmd+0 KeyAction('change_font_size', (False, None, 0.0))
	cmd+1 KeyAction('goto_tab', (1,))
	cmd+2 KeyAction('goto_tab', (2,))
	cmd+3 KeyAction('goto_tab', (3,))
	cmd+4 KeyAction('goto_tab', (4,))
	cmd+5 KeyAction('goto_tab', (5,))
	cmd+6 KeyAction('goto_tab', (6,))
	cmd+7 KeyAction('goto_tab', (7,))
	cmd+8 KeyAction('goto_tab', (8,))
	cmd+9 KeyAction('goto_tab', (9,))
	cmd+n KeyAction('new_os_window_with_cwd')
	cmd+r KeyAction('set_tab_title')
	cmd+t KeyAction('new_tab_with_cwd')
	cmd+w KeyAction('close_window')
Colors:
	active_border_color             #9e9694   
	active_tab_background           #f0edec   
	active_tab_foreground           #2c363c   
	background                      #f0edec   
	color0                          #f0edec   
	color1                          #a8334c   
	color10                         #3f5a22   
	color11                         #803d1c   
	color12                         #1d5573   
	color13                         #7b3b70   
	color14                         #2b747c   
	color15                         #4f5e68   
	color2                          #4f6c31   
	color3                          #944927   
	color4                          #286486   
	color5                          #88507d   
	color6                          #3b8992   
	color7                          #2c363c   
	color8                          #cfc1ba   
	color9                          #94253e   
	cursor                          #2c363c   
	foreground                      #2c363c   
	inactive_border_color           #ded6d3   
	inactive_tab_background         #ccc8c7   
	inactive_tab_foreground         #ffffff   
	selection_background            #d2dfe7   
	selection_foreground            #2c363c   
	tab_bar_background              #a8a4a3   
	url_color                       #1d5573   
@jryom jryom added the bug label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant