Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select_tab should not change key-tab mapping #4792

Closed
andersbetner opened this issue Mar 5, 2022 · 1 comment
Closed

Select_tab should not change key-tab mapping #4792

andersbetner opened this issue Mar 5, 2022 · 1 comment

Comments

@andersbetner
Copy link

This is more of a question about a design decision.
Is your feature request related to a problem? Please describe.
I have three tabs open (tab1, tab2, tab3)
When I hit the mapped key for select_tab I get presented with different "jump keys" depending on which tab I am jumping from.

# Active tab == tab1
select_tab shows:
1 tab2
2 tab3
# I have to press 1 to get to tab2
# Active tab == tab2
select_tab shows:
1 tab1
2 tab3
# I have to press 1 to go to tab1
# I have to press 2 to go to tab3
# Active tab == tab3
select_tab shows:
1 tab1
2 tab2
# I have to press 2 to go to tab2

Describe the solution you'd like
It would be better for the muscle memory to keep the list the same in all tabs.
There is a higher cognitive load to either remember which tab has which shortcut depending of the active tab or to have to scan the list every time.
Would it be possible to present list list like this?

Active tab == tab1
select_tab shows:
1 tab1
2 tab2
3 tab3
Active tab == tab2
select_tab shows:
1 tab1
2 tab2
3 tab3

Yes you would be able to jump to the current tab, but just let me do that. I can handle it.

Describe alternatives you've considered

Additional context

If I'm not too far off, the only thing needed wold be to get rid of the condition in the list comprehension here

((t.id, format_tab_title(t)) for t in self.all_tabs if t is not ct),

I'm aware this would mess with peoples brains at first, but wouldn't it be a better design?

@page-down
Copy link
Contributor

I had made a similar suggestion for the visual window selection feature.
I also don't really like the fact that the selection keys changes dynamically in this usage scenario.
The current tab can be grayed out in the list.

This way the order of tab candidates in the list is consistent with the actual order, which will improve the user experience.

@andersbetner andersbetner changed the title Select_tab should change assigned keys Select_tab should not change key-tab mapping Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants