Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too bright colors in 0.25.1 on MacOS #5129

Closed
evmorov opened this issue May 26, 2022 · 7 comments
Closed

Too bright colors in 0.25.1 on MacOS #5129

evmorov opened this issue May 26, 2022 · 7 comments
Labels

Comments

@evmorov
Copy link

evmorov commented May 26, 2022

Describe the bug

The colours in 0.25.1 are too bright/saturated compared to all the previous releases.

I'm aware of the new macos_colorspace. I've tried srgb, default and displayp3. But nothing seems to work to make it how it was.

Screenshots

image

@evmorov evmorov added the bug label May 26, 2022
@kovidgoyal
Copy link
Owner

There have been no changes to color rendering in 2.5.1 that I know of.
2.5.0 and 2.5.1 (by default) both use the sRGB colorspace. Try inserting
a printf at line 1733 in in glfw/cocoa_window.m to verify.

@evmorov
Copy link
Author

evmorov commented May 26, 2022

@kovidgoyal am I correct that you understood the problem and fixed it in cb55878?

@kovidgoyal
Copy link
Owner

yes

@evmorov
Copy link
Author

evmorov commented May 26, 2022

Thanks! I'll wait until 2.5.2 then!

@mcmillion
Copy link

Looks like this is still broken in 0.25.2.

@evmorov
Copy link
Author

evmorov commented Jun 7, 2022

Looks like this is still broken in 0.25.2.

Same for me.

@kovidgoyal can you reopen?

@kovidgoyal
Copy link
Owner

Man, this setting is cursed. Here you go: 80ad596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants