Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input source is not changed with Japanese keyboard mac. #5232

Closed
tamanishi opened this issue Jun 25, 2022 · 2 comments
Closed

Input source is not changed with Japanese keyboard mac. #5232

tamanishi opened this issue Jun 25, 2022 · 2 comments
Labels

Comments

@tamanishi
Copy link

Describe the bug
Version 0.24.2 or later, Input source is not changed when pressing Eisu key and Kana key on Japanese keyboard mac.

To Reproduce
Steps to reproduce the behavior:

  1. Press Eisu key.
  2. Press Kana key.
  3. Input source is not changed to Japanese - Romaji.

Additional context

  • Input source changes at 0.24.1.
~ ❯ kitty --version
kitty 0.24.1 created by Kovid Goyal
~ ❯ kitty --config=NONE --debug-input
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
Move mouse_button: -1 mods: none grabbed: 0
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
Release: native_key: 0x66 (<cc>) glfw_key: 0x0 mods: none 
Release: native_key: 0x68 (<cc>) glfw_key: 0x0 mods: none 
Release: native_key: 0x66 (<cc>) glfw_key: 0x0 mods: none 
Release: native_key: 0x68 (<cc>) glfw_key: 0x0 mods: none 
Release: native_key: 0x66 (<cc>) glfw_key: 0x0 mods: none 
Release: native_key: 0x68 (<cc>) glfw_key: 0x0 mods: none 
  • Input source not changes at 0.24.2.
~ ❯ kitty --version
kitty 0.24.2 created by Kovid Goyal
~ ❯ kitty --config=NONE --debug-input
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
Move mouse_button: -1 mods: none grabbed: 0
updateIMEPosition: left=0.000000, top=6.000000, width=7.000000, height=12.500000
---------------- key down -------------------
NSEvent: type=KeyDown loc=(372.661,1006.68) time=22044.0 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=102
Press: native_key: 0x66 (<cc>) glfw_key: 0x0 mods: none char_count: 1 deadKeyState: 0 repeat: 0 
	insertText:  replacementRange: (9223372036854775807, 0)
text: <none> glfw_key: UNKNOWN marked_text: ()
on_key_input: glfw key: 0x0 native_code: 0x66 action: PRESS mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring as keyboard mode does not support encoding this event
----------------- key up --------------------
NSEvent: type=KeyUp loc=(372.661,1006.68) time=22044.0 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=102
Release: native_key: 0x66 (<cc>) glfw_key: 0x0 mods: none 
on_key_input: glfw key: 0x0 native_code: 0x66 action: RELEASE mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring release event for previous press that was handled as shortcut
---------------- key down -------------------
NSEvent: type=KeyDown loc=(372.661,1006.68) time=22044.2 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=104
Press: native_key: 0x68 (<cc>) glfw_key: 0x0 mods: none char_count: 1 deadKeyState: 0 repeat: 0 
	insertText:  replacementRange: (9223372036854775807, 0)
text: <none> glfw_key: UNKNOWN marked_text: ()
on_key_input: glfw key: 0x0 native_code: 0x68 action: PRESS mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring as keyboard mode does not support encoding this event
----------------- key up --------------------
NSEvent: type=KeyUp loc=(372.661,1006.68) time=22044.2 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=104
Release: native_key: 0x68 (<cc>) glfw_key: 0x0 mods: none 
on_key_input: glfw key: 0x0 native_code: 0x68 action: RELEASE mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring release event for previous press that was handled as shortcut
---------------- key down -------------------
NSEvent: type=KeyDown loc=(372.661,1006.68) time=22044.4 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=102
Press: native_key: 0x66 (<cc>) glfw_key: 0x0 mods: none char_count: 1 deadKeyState: 0 repeat: 0 
	insertText:  replacementRange: (9223372036854775807, 0)
text: <none> glfw_key: UNKNOWN marked_text: ()
on_key_input: glfw key: 0x0 native_code: 0x66 action: PRESS mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring as keyboard mode does not support encoding this event
----------------- key up --------------------
NSEvent: type=KeyUp loc=(372.661,1006.68) time=22044.4 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=102
Release: native_key: 0x66 (<cc>) glfw_key: 0x0 mods: none 
on_key_input: glfw key: 0x0 native_code: 0x66 action: RELEASE mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring release event for previous press that was handled as shortcut
---------------- key down -------------------
NSEvent: type=KeyDown loc=(372.661,1006.68) time=22044.6 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=104
Press: native_key: 0x68 (<cc>) glfw_key: 0x0 mods: none char_count: 1 deadKeyState: 0 repeat: 0 
	insertText:  replacementRange: (9223372036854775807, 0)
text: <none> glfw_key: UNKNOWN marked_text: ()
on_key_input: glfw key: 0x0 native_code: 0x68 action: PRESS mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring as keyboard mode does not support encoding this event
----------------- key up --------------------
NSEvent: type=KeyUp loc=(372.661,1006.68) time=22044.6 flags=0x100 win=0x7fd3b3f23660 winNum=6917 ctxt=0x0 chars="" unmodchars="" repeat=0 keyCode=104
Release: native_key: 0x68 (<cc>) glfw_key: 0x0 mods: none 
on_key_input: glfw key: 0x0 native_code: 0x68 action: RELEASE mods: none text: '' state: 0 updateIMEPosition: left=28.000000, top=31.000000, width=7.000000, height=12.500000
ignoring release event for previous press that was handled as shortcut
@tamanishi tamanishi added the bug label Jun 25, 2022
@kovidgoyal
Copy link
Owner

This will be because all key events are now processed by kitty not macOS
in order to fix other problems with macOS default key handling. I dont
have this hardware so its hard fro me to fix this, patches are welcome,
if you want to work on it I will guide you as to where the relevant code
is.

@tamanishi
Copy link
Author

patches are welcome,
if you want to work on it I will guide you as to where the relevant code
is.

Thanks.
Please tell me which part of the code I should check.
I will try to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants