New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 small issues on macOS #524
Comments
|
|
I'm not a mac user, but why would the sortcut work when you areont he desktop? Presumably the shortcut will go to whatever application has focus or the desktop itself. |
when I try to create a new window, kitty is obviously the focused app. it creates a new window only when I'm on the screen with a kitty window already open. If I try to do the same with e.g. Terminal.app, I can create a new window the way I described. |
OK I'll take a look at it the next time I have access to a mac. |
thanks! |
Maybe I can help. I can test it on my mac tomorrow. |
I can confirm that kitty does not create a new window on macOS when it is not on the current desktop. This does not depend on kitty being fullscreen or not, kitty can also be a normal sized window on another desktop. |
I can't reproduce this bug. I clicked the green button to make kitty fullscreen, pressed the shortcut(Ctrl+Shift+n) to create a new os window, a new window had spawned.
In my case maximizing kitty is perfectly fit on the screen. What's in your I can't reproduce it. I have multiple monitors connected to my mac, launched a kitty instance, and created a new os window, everything seems to work for me as long as a kitty window has focused on it. |
you missed one step. after clicking the green button, you have to press ctrl-left to go back to the desktop, press cmd-tab to be sure kitty is the focused app, and then press ctrl-shift-n
On the macbook native screen or on an external monitor? on my macbook screen kitty fits perfectly, but when the same fullscreen window is on an external monitor there's a small slice missing on the left border |
I cannot reproduce this either, although I dont think I understand it. Steps It tried:
so what do I do now? How do I make kitty the focused application without bringing any of its windows into focus? If I press cmd+tab the kitty window comes into focus and all kitty shortcuts work. |
Go to System Preferences > Mission Control and disable "When switching to an application, switch to a Space with open windows for the application", follow the four steps as you described them and then click the kitty icon in the dock or switch to kitty using cmd+tab. Kitty should now be the focused application without any open windows on that space. |
Ah, I see. Well, that's a fundamental limitation of cocoa/gflw. In cocoa as far as I know (short of running as root) you can only get events such as keypress events on a focused window. If no window is focused you dont get key events. This is reflected in the design of glfw, where you only get key events with a window callback. I assume other cocoa applications work around that by defining actions in the global menu, these are triggered by the OS even when no window is focused. kitty has no global shortcuts (apart from the basic ones all cocoa applications have. So to fix this I assume kitty would need to create such a global shortcut. The annoying part would be mapping back from kitty's shortcut definition to cocoa key names/modifier masks, which would be a lot of code. I might get to it someday... |
Note I have not actually tested the fix,beyond making sure that moving the new_os_window shortcut to the global menu does not break the shortcut. |
This fix has been working well for me for the past couple days, thanks! |
If I run kitty, make the window fullscreen, go back to the desktop, I cannot create another kitty window. It works only if I have the first kitty window visibile on the desktop
when I have an external monitor attached to my macbook (with the lid closed, i.e. I only have the external monitor in use) when I make the kitty window fullscreen there are some pixels on the left border of the screen which are not visibile, so the characters on the first column are not completely visible. it's like a little less than half column, so not a big deal, but slightly annoying nevertheless :)
thanks for your work!
The text was updated successfully, but these errors were encountered: