Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make margin tint optional, i.e. bring "bug" 3933 back as configurable option #5596

Closed
cmcallister opened this issue Oct 17, 2022 · 1 comment

Comments

@cmcallister
Copy link

Is your feature request related to a problem? Please describe.
It's not really an problem but recently #3933 was "fixed" but I actually had set wide margins not realizing this was considererd a bug; it worked at giving a "gaps" like feel that you see in a lot of tiling WM.

Describe the solution you'd like
a config option that either toggles on the former lack of tinting on margins or an option that allows for setting the value for margins separately. The former seems simpler and certainly sufficient.

It feels like since this was considered a bug it's not likely to be brought back but I liked it

@kovidgoyal
Copy link
Owner

Not something I care to spend time on personally, but it should be a
very simple patch. Basically, line 970 in shaders.c tint_opacity should
be set to zero to avoid a tint over the gaps area.

I will accept a patch adding an option such as

background_tint_gaps (default 1.0)

then the final value of tint_opacity should be OPT(background_tint) * OPT(background_tint_gaps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants