Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing over SSH not working with Home Assistant OS #5630

Closed
ralphioli opened this issue Oct 27, 2022 · 2 comments
Closed

Editing over SSH not working with Home Assistant OS #5630

ralphioli opened this issue Oct 27, 2022 · 2 comments
Labels

Comments

@ralphioli
Copy link

Describe the bug
Basically what the title says. Whenever I try to edit any file with edit-in-kitty on Home Assistant OS over SSH, I see the following:

bash: local: `255': not a valid identifier
bash: local: `3618516': not a valid identifier
bash: local: `925696': not a valid identifier
bash: [: : integer expression expected
Waiting for editing to be completed...

Then nothing happens.

To Reproduce
Steps to reproduce the behavior:

  1. Using the SSH kitten, connect to a server running Home Assistant OS with the official Terminal & SSH addon
  2. Try to edit any file with the edit-in-kitty command
  3. See error

Environment details

kitty 0.26.4 created by Kovid Goyal
Linux fedora 5.19.16-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Sun Oct 16 22:50:04 UTC 2022 x86_64
S
Kernel 5.19.16-200.fc36.x86_64 on an x86_64 (/dev/tty)

Running under: Wayland
Frozen: False
Paths:
  kitty: /usr/bin/kitty
  base dir: /usr/lib64/kitty
  extensions dir: /usr/lib64/kitty/kitty
  system shell: /usr/bin/fish
Loaded config files:
  /home/ralph/.config/kitty/kitty.conf

Config options different from defaults:
allow_remote_control     yes
cursor_text_color        None
enable_audio_bell        False
enabled_layouts          ['tall', 'fat', 'vertical', 'grid', 'stack']
font_family              Hack Nerd Font
font_size                10.5
shell_integration        frozenset({'invalid'})
wayland_titlebar_color   555887618
window_resize_step_cells 1
window_resize_step_lines 1
Added shortcuts:
	kitty_mod+alt+, →  move_tab_backward
	kitty_mod+alt+. →  move_tab_forward
	kitty_mod+alt+enter →  launch
	kitty_mod+y →  detach_window ask
Changed shortcuts:
	kitty_mod+, →  previous_tab
	kitty_mod+. →  next_tab
	kitty_mod+enter →  launch --cwd=current
Colors:
	active_tab_background    #f8f8f2   
	active_tab_foreground    #282a36   
	background               #282a36   
	color0                   #21222c   
	color1                   #ff5555   
	color10                  #69ff94   
	color11                  #ffffa5   
	color12                  #d6acff   
	color13                  #ff92df   
	color14                  #a4ffff   
	color2                   #50fa7b   
	color3                   #f1fa8c   
	color4                   #bd93f9   
	color5                   #ff79c6   
	color6                   #8be9fd   
	color7                   #f8f8f2   
	color8                   #6272a4   
	color9                   #ff6e6e   
	cursor                   #f8f8f2   
	foreground               #f8f8f2   
	inactive_tab_background  #6272a4   
	inactive_tab_foreground  #282a36   
	mark1_background         #ff5555   
	mark1_foreground         #282a36   
	selection_background     #44475a   
	selection_foreground     #ffffff   
	url_color                #8be9fd   

Important environment variables seen by the kitty process:
	PATH                                /home/ralph/.cargo/bin:/home/ralph/.local/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin
	LANG                                en_US.UTF-8
	EDITOR                              nvim
	SHELL                               /usr/bin/fish
	DISPLAY                             :0
	WAYLAND_DISPLAY                     wayland-0
	USER                                ralph
	XDG_MENU_PREFIX                     gnome-
	XDG_SESSION_DESKTOP                 gnome
	XDG_SESSION_TYPE                    wayland
	XDG_CURRENT_DESKTOP                 GNOME
	XDG_SESSION_CLASS                   user
	XDG_RUNTIME_DIR                     /run/user/1000
	XDG_DATA_DIRS                       /home/ralph/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share/:/usr/share/

Additional context

  • My computer is running Fedora 36 with Kitty version 0.26.4
  • The server I'm connecting to runs Home Assistant OS 9.3 with Terminal & SSH add-on version 9.6.1
  • kitty --config NONE does not solve the issue
@ralphioli ralphioli added the bug label Oct 27, 2022
@kovidgoyal
Copy link
Owner

I dont know what home assistant OS is and I'm afraid I am not going to
install an entire OS to debug this. From the error message it sounds
like the version of bash is too old. If you have the ability to use a
more modern bash I suggest upgrading, or using an alternate shell, like
zsh or fish.

Otherwise at some point edit-in-kitty will be implemented using a static
binary rather than shell script, at which time this should be
automatically fixed.

@hirad1986
Copy link

I get the same Waiting for editing to be completed... as well. From Arch to Arch and Ubuntu. I've also noticed it happens whenever the file is longer than just a few lines.
kitty --version : 0.26.4
bash --version: 5.1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants