Skip to content

unicode_input #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Icelk opened this issue Apr 26, 2023 · 3 comments
Closed

unicode_input #6214

Icelk opened this issue Apr 26, 2023 · 3 comments
Labels

Comments

@Icelk
Copy link

Icelk commented Apr 26, 2023

Describe the bug
The new go unicode_input unnecessarily serializes the favourites. This removes comments and reorders favourites, which makes the feature unusable

To Reproduce
Steps to reproduce the behavior:

  • press Ctrl+Shift+U, then F4, then F12. Add any character or comment
  • Save file & quit
  • See how they are reordered & if pressing F12, the comments are gone

Screenshots
If applicable, add screenshots to help explain your problem.

Environment details

kitty 0.28.1 created by Kovid Goyal
Linux erik-skoldator 6.2.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Sat, 11 Mar 2023 14:28:13 +0000 x86_64
Arch Linux 6.2.5-arch1-1 (/dev/tty)

�[?12h�[?25h�[?25h�[?0cDISTRIB_ID="Arch"
DISTRIB_RELEASE="rolling"
DISTRIB_DESCRIPTION="Arch Linux"
Running under: Wayland
Frozen: False
Paths:
  kitty: /usr/bin/kitty
  base dir: /usr/lib/kitty
  extensions dir: /usr/lib/kitty/kitty
  system shell: /usr/bin/fish
Loaded config files:
  /home/icelk/.config/kitty/kitty.conf

Config options different from defaults:
background_opacity            0.8
click_interval                0.3
cursor_shape                  2
cursor_stop_blinking_after    5.0
focus_follows_mouse           True
font_family                   Fira Code
font_features:
{'FiraCode-Regular': ('+ss07', '+ss09', '+ss10', '+cv02', '+cv14')}
font_size                     10.7
placement_strategy            top-left
scrollback_lines              4096
scrollback_pager              ['nvim', '-c', 'setlocal noswapfile', '-c', 'autocmd TermOpen * setlocal signcolumn=no number& relativenumber& list& showtabline=0 foldcolumn=0', '-c', 'autocmd VimEnter * normal G', '-c', 'nmap q :q<CR>', '-c', 'silent write! /tmp/kitty_scrollback_buffer | te cat /tmp/kitty_scrollback_buffer -']
scrollback_pager_history_size 10485760
selection_foreground          None
touch_scroll_multiplier       5.0
wheel_scroll_multiplier       3.0
Added shortcuts:
	ctrl+t →  new_tab
Changed shortcuts:
	kitty_mod+t →  set_tab_title
Colors:
	background                    #3d4044   
	color0                        #1d1f21   
	color1                        #cc6666   
	color10                       #9ec400   
	color11                       #f0c674   
	color12                       #81a2be   
	color13                       #b77ee0   
	color14                       #54ced6   
	color15                       #6a6f7a   
	color2                        #b5bd68   
	color3                        #e6c547   
	color4                        #81a2be   
	color5                        #b294bb   
	color6                        #70c0ba   
	color7                        #b8c5d8   
	color8                        #666666   
	color9                        #ff3334   
	cursor                        #ffffff   
	cursor_text_color             #1d1f21   
	foreground                    #e8eff2   
	selection_background          #66666b   

Important environment variables seen by the kitty process:
	PATH                                /usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
	LANG                                en_GB.UTF-8
	EDITOR                              nvim
	SHELL                               /usr/bin/fish
	DISPLAY                             :0
	WAYLAND_DISPLAY                     wayland-1
	USER                                icelk
	XCURSOR_SIZE                        24
	XDG_BACKEND                         wayland
	XDG_SEAT                            seat0
	XDG_SESSION_TYPE                    wayland
	XDG_CURRENT_DESKTOP                 Hyprland
	XDG_SESSION_CLASS                   user
	XDG_VTNR                            1
	XDG_SESSION_ID                      1
	XDG_RUNTIME_DIR                     /run/user/1000

@Icelk Icelk added the bug label Apr 26, 2023
@Icelk
Copy link
Author

Icelk commented Apr 26, 2023

Is it reasonable to just not serialize the file unless it contains errors?

@Icelk
Copy link
Author

Icelk commented Apr 26, 2023

Comments after the hex unicode char are replaced by the character description, which is not always wanted.

@Icelk
Copy link
Author

Icelk commented Apr 26, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant