crashing on latest version.

[derspyy]

Describe the bug

To Reproduce

it's simply crashing on launch on my system, though there is an error message:

Error message

X Error of failed request:  BadLength (poly request too large or internal Xlib length error)
  Major opcode of failed request:  18 (X_ChangeProperty)
  Serial number of failed request:  353
  Current serial number in output stream:  353

Environment details

it must be noted that this was generated by downgrading to 0.28.1.

kitty 0.28.1 created by Kovid Goyal
Linux archlinux 6.4.6-arch1-1 #1 SMP PREEMPT_DYNAMIC Mon, 24 Jul 2023 20:19:38 +0000 x86_64
Arch Linux 6.4.6-arch1-1 (/dev/tty)

DISTRIB_ID="Arch"
DISTRIB_RELEASE="rolling"
DISTRIB_DESCRIPTION="Arch Linux"
Running under: X11
Frozen: False
Paths:
  kitty: /usr/bin/kitty
  base dir: /usr/lib/kitty
  extensions dir: /usr/lib/kitty/kitty
  system shell: /usr/bin/fish
Loaded config files:
  /home/piuvas/.config/kitty/kitty.conf

Config options different from defaults:
font_family             Mononoki Nerd Fonts
Added shortcuts:
	f4 →  launch --location=split
Colors:
	active_tab_background   #26233a   
	active_tab_foreground   #e0def4   
	background              #191724   
	color0                  #26233a   
	color1                  #eb6f92   
	color10                 #31748f   
	color11                 #f6c177   
	color12                 #9ccfd8   
	color13                 #c4a7e7   
	color14                 #ebbcba   
	color15                 #e0def4   
	color2                  #31748f   
	color3                  #f6c177   
	color4                  #9ccfd8   
	color5                  #c4a7e7   
	color6                  #ebbcba   
	color7                  #e0def4   
	color8                  #6e6a86   
	color9                  #eb6f92   
	cursor                  #524f67   
	cursor_text_color       #e0def4   
	foreground              #e0def4   
	inactive_tab_background #191724   
	inactive_tab_foreground #6e6a86   
	selection_background    #403d52   
	selection_foreground    #e0def4   
	url_color               #c4a7e7   

Important environment variables seen by the kitty process:
	PATH                                /usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/home/piuvas/.dotnet/tools:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/rustup/bin
	LANG                                en_US.UTF-8
	SHELL                               /usr/bin/fish
	DISPLAY                             :0.0
	USER                                piuvas
	XDG_CONFIG_DIRS                     /etc/xdg
	XDG_SESSION_PATH                    /org/freedesktop/DisplayManager/Session0
	XDG_MENU_PREFIX                     xfce-
	XDG_SEAT                            seat0
	XDG_SESSION_DESKTOP                 xfce
	XDG_SESSION_TYPE                    x11
	XDG_GREETER_DATA_DIR                /var/lib/lightdm-data/piuvas
	XDG_CURRENT_DESKTOP                 XFCE
	XDG_SEAT_PATH                       /org/freedesktop/DisplayManager/Seat0
	XDG_SESSION_CLASS                   user
	XDG_VTNR                            7
	XDG_SESSION_ID                      2
	XDG_RUNTIME_DIR                     /run/user/1000
	XDG_DATA_DIRS                       /usr/local/share:/usr/share

Additional context

kitty --config NONE does crash.

[kovidgoyal]

sadly the error message from the X server doesnt contain enough
information to be useful. If you tell me some more about your system I
will try to reproduce, but I dont expect I will be able too as this is
likely something highly system specific. If you can build kitty from
source and want to debug yourself, look for calls to XChangeProperty and
put prints around them to find the culprit.

[derspyy]

found the issue... custom icon in the config folder. lols.

[kovidgoyal]

was the icon too large or something?

[derspyy]

https://github.com/rose-pine/kitty/blob/main/icons/rose-pine-kitty-icon.png

[kovidgoyal]

Yeah that image is too large. X11 can take max 128x128 or 256x256
(depending on server config).