Double-tap by touchpad on the titlebar doesn't maximize/unmaximize the window in GNOME, Wayland

[darkblaze69]

Describe the bug
Double-tap by touchpad on the titlebar doesn't maximize/unmaximize the window in GNOME, Wayland.

Judging by the wayland log it wants to move the window instead.

Only by tripple-tapping it can be maximized/unmaximized.

To Reproduce
Steps to reproduce the behavior:

1. double tap on by touchpad on the titlebar on unmaximized window
2. it does nothing (in log it registers xdg_toplevel#30.move)
3. double tap on by touchpad on the titlebar on maximized window
4. it does nothing

Wayland_debug log

• On 19:08:30 I double tapped > does nothing
• On 19:08:35 I tripple tapped > it got maximized

Wayland debug log snippet

$ WAYLAND_DEBUG=1 kitty 2>&1 | ts
...
Nov 17 19:08:23 [1430594.759] {Default Queue} wl_pointer#23.motion(64506455, 449.13671875, 10.89843750)
Nov 17 19:08:23 [1430594.871] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:23 [1430671.126] {Default Queue} xdg_wm_base#10.ping(64506531)
Nov 17 19:08:23 [1430671.139] {Default Queue}  -> xdg_wm_base#10.pong(64506531)
Nov 17 19:08:23 [1430671.142] {Default Queue} wl_pointer#23.motion(64506531, 446.98828125, 10.89843750)
Nov 17 19:08:23 [1430671.222] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:30 [1437660.974] {Default Queue} xdg_wm_base#10.ping(64513493)
Nov 17 19:08:30 [1437660.997] {Default Queue}  -> xdg_wm_base#10.pong(64513493)
Nov 17 19:08:30 [1437661.000] {Default Queue} wl_pointer#23.button(4686, 64513493, 272, 1)
Nov 17 19:08:30 [1437661.005] {Default Queue}  -> xdg_toplevel#30.move(wl_seat#13, 4686)
Nov 17 19:08:30 [1437661.007] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:30 [1437661.525] {Default Queue} wl_pointer#23.leave(4687, wl_surface#50)
Nov 17 19:08:30 [1437661.537] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:30 [1437661.541] {Default Queue} wl_keyboard#24.leave(4688, wl_surface#25)
Nov 17 19:08:30 [1437661.662] {Default Queue}  -> zwp_text_input_v3#3.enable()
Nov 17 19:08:30 [1437661.669] {Default Queue}  -> zwp_text_input_v3#3.set_content_type(0, 13)
Nov 17 19:08:30 [1437661.673] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:30 [1437661.679] {Default Queue} zwp_text_input_v3#3.leave(wl_surface#25)
Nov 17 19:08:30 [1437661.683] {Default Queue}  -> zwp_text_input_v3#3.disable()
Nov 17 19:08:30 [1437661.686] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:30 [1437661.759] {mesa egl surface queue} wl_buffer#45.release()
Nov 17 19:08:30 [1437661.763] {mesa egl surface queue} wl_callback#43.done(4680)
Nov 17 19:08:30 [1437662.878] {mesa egl surface queue}  -> wl_surface#25.attach(wl_buffer#45, 0, 0)
Nov 17 19:08:30 [1437662.884] {mesa egl surface queue}  -> wl_surface#25.damage(0, 0, 2147483647, 2147483647)
Nov 17 19:08:30 [1437662.885] {mesa egl surface queue}  -> wl_surface#25.commit()
Nov 17 19:08:30 [1437662.887] {mesa egl surface queue}  -> wl_display#1.sync(new id wl_callback#43)
Nov 17 19:08:30 [1437662.891] {Default Queue}  -> wl_surface#25.frame(new id wl_callback#100)
Nov 17 19:08:30 [1437662.892] {Default Queue}  -> wl_surface#25.commit()
Nov 17 19:08:30 [1437663.112] {Display Queue} wl_display#1.delete_id(43)
Nov 17 19:08:30 [1437672.443] {Display Queue} wl_display#1.delete_id(100)
Nov 17 19:08:30 [1437672.454] {Default Queue} wl_callback#100.done(64513533)
Nov 17 19:08:30 [1437863.695] {Default Queue} wl_pointer#23.enter(4689, wl_surface#50, 446.98828125, 10.89843750)
Nov 17 19:08:30 [1437863.864] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:30 [1437863.867] {Default Queue} wl_keyboard#24.enter(4690, wl_surface#25, array[0])
Nov 17 19:08:30 [1437863.912] {Default Queue}  -> zwp_text_input_v3#3.disable()
Nov 17 19:08:30 [1437863.914] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:30 [1437863.921] {Default Queue}  -> zwp_text_input_v3#3.disable()
Nov 17 19:08:30 [1437863.922] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:30 [1437863.924] {Default Queue} wl_keyboard#24.modifiers(4690, 0, 0, 0, 0)
Nov 17 19:08:30 [1437863.927] {Default Queue} wl_data_device#14.data_offer(new id wl_data_offer#4278190083)
Nov 17 19:08:30 [1437863.929] {Default Queue} wl_data_offer#4278190083.offer("text/plain;charset=utf-8")
Nov 17 19:08:30 [1437863.930] {Default Queue} wl_data_device#14.selection(wl_data_offer#4278190083)
Nov 17 19:08:30 [1437863.932] {Default Queue}  -> wl_data_offer#4278190081.destroy()
Nov 17 19:08:30 [1437863.934] {Default Queue} zwp_primary_selection_device_v1#15.data_offer(new id zwp_primary_selection_offer_v1#4278190082)
Nov 17 19:08:30 [1437863.936] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("text/plain")
Nov 17 19:08:30 [1437863.937] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("text/plain;charset=utf-8")
Nov 17 19:08:30 [1437863.938] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("STRING")
Nov 17 19:08:30 [1437863.938] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("text/plain")
Nov 17 19:08:30 [1437863.939] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("TEXT")
Nov 17 19:08:30 [1437863.940] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("COMPOUND_TEXT")
Nov 17 19:08:30 [1437863.941] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("UTF8_STRING")
Nov 17 19:08:30 [1437863.941] {Default Queue} zwp_primary_selection_offer_v1#4278190082.offer("text/plain;charset=utf-8")
Nov 17 19:08:30 [1437863.942] {Default Queue} zwp_primary_selection_device_v1#15.selection(zwp_primary_selection_offer_v1#4278190082)
Nov 17 19:08:30 [1437863.944] {Default Queue}  -> zwp_primary_selection_offer_v1#4278190080.destroy()
Nov 17 19:08:30 [1437863.946] {Default Queue} zwp_text_input_v3#3.enter(wl_surface#25)
Nov 17 19:08:30 [1437863.948] {Default Queue}  -> zwp_text_input_v3#3.enable()
Nov 17 19:08:30 [1437863.949] {Default Queue}  -> zwp_text_input_v3#3.set_content_type(0, 13)
Nov 17 19:08:30 [1437863.950] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:30 [1437863.980] {mesa egl surface queue} wl_callback#43.done(4688)
Nov 17 19:08:30 [1437863.983] {mesa egl surface queue} wl_buffer#32.release()
Nov 17 19:08:30 [1437864.082] {mesa egl surface queue}  -> wl_surface#25.attach(wl_buffer#32, 0, 0)
Nov 17 19:08:30 [1437864.086] {mesa egl surface queue}  -> wl_surface#25.damage(0, 0, 2147483647, 2147483647)
Nov 17 19:08:30 [1437864.087] {mesa egl surface queue}  -> wl_surface#25.commit()
Nov 17 19:08:30 [1437864.088] {mesa egl surface queue}  -> wl_display#1.sync(new id wl_callback#43)
Nov 17 19:08:30 [1437864.092] {Default Queue}  -> wl_surface#25.frame(new id wl_callback#100)
Nov 17 19:08:30 [1437864.093] {Default Queue}  -> wl_surface#25.commit()
Nov 17 19:08:30 [1437864.099] {Default Queue} zwp_text_input_v3#3.done(21)
Nov 17 19:08:30 [1437864.271] {Display Queue} wl_display#1.delete_id(43)
Nov 17 19:08:30 [1437872.536] {Display Queue} wl_display#1.delete_id(100)
Nov 17 19:08:30 [1437872.547] {Default Queue} wl_callback#100.done(64513733)
Nov 17 19:08:30 [1438041.564] {Default Queue} wl_pointer#23.button(4691, 64513722, 272, 0)
Nov 17 19:08:30 [1438041.578] {Default Queue}  -> xdg_toplevel#30.move(wl_seat#13, 4691)
Nov 17 19:08:30 [1438041.584] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:35 [1442602.062] {Default Queue} xdg_wm_base#10.ping(64518414)
Nov 17 19:08:35 [1442602.077] {Default Queue}  -> xdg_wm_base#10.pong(64518414)
Nov 17 19:08:35 [1442602.080] {Default Queue} wl_pointer#23.button(4694, 64518414, 272, 1)
Nov 17 19:08:35 [1442602.084] {Default Queue}  -> xdg_toplevel#30.move(wl_seat#13, 4694)
Nov 17 19:08:35 [1442602.087] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:35 [1442602.351] {Default Queue} wl_pointer#23.leave(4695, wl_surface#50)
Nov 17 19:08:35 [1442602.363] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:35 [1442602.370] {Default Queue} wl_keyboard#24.leave(4696, wl_surface#25)
Nov 17 19:08:35 [1442602.456] {Default Queue}  -> zwp_text_input_v3#3.enable()
Nov 17 19:08:35 [1442602.460] {Default Queue}  -> zwp_text_input_v3#3.set_content_type(0, 13)
Nov 17 19:08:35 [1442602.463] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:35 [1442602.466] {Default Queue} zwp_text_input_v3#3.leave(wl_surface#25)
Nov 17 19:08:35 [1442602.468] {Default Queue}  -> zwp_text_input_v3#3.disable()
Nov 17 19:08:35 [1442602.469] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:35 [1442602.524] {mesa egl surface queue} wl_callback#43.done(4690)
Nov 17 19:08:35 [1442602.530] {mesa egl surface queue} wl_buffer#45.release()
Nov 17 19:08:35 [1442603.807] {mesa egl surface queue}  -> wl_surface#25.attach(wl_buffer#45, 0, 0)
Nov 17 19:08:35 [1442603.814] {mesa egl surface queue}  -> wl_surface#25.damage(0, 0, 2147483647, 2147483647)
Nov 17 19:08:35 [1442603.815] {mesa egl surface queue}  -> wl_surface#25.commit()
Nov 17 19:08:35 [1442603.816] {mesa egl surface queue}  -> wl_display#1.sync(new id wl_callback#43)
Nov 17 19:08:35 [1442603.824] {Default Queue}  -> wl_surface#25.frame(new id wl_callback#100)
Nov 17 19:08:35 [1442603.825] {Default Queue}  -> wl_surface#25.commit()
Nov 17 19:08:35 [1442604.208] {Display Queue} wl_display#1.delete_id(43)
Nov 17 19:08:35 [1442606.101] {Display Queue} wl_display#1.delete_id(100)
Nov 17 19:08:35 [1442606.107] {Default Queue} wl_callback#100.done(64518467)
Nov 17 19:08:35 [1442788.689] {Default Queue} wl_pointer#23.enter(4697, wl_surface#50, 446.98828125, 10.89843750)
Nov 17 19:08:35 [1442788.848] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:35 [1442788.851] {Default Queue} wl_keyboard#24.enter(4698, wl_surface#25, array[0])
Nov 17 19:08:35 [1442788.914] {Default Queue}  -> zwp_text_input_v3#3.disable()
Nov 17 19:08:35 [1442788.917] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:35 [1442788.925] {Default Queue}  -> zwp_text_input_v3#3.disable()
Nov 17 19:08:35 [1442788.926] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:35 [1442788.927] {Default Queue} wl_keyboard#24.modifiers(4698, 0, 0, 0, 0)
Nov 17 19:08:35 [1442788.931] {Default Queue} wl_data_device#14.data_offer(new id wl_data_offer#4278190080)
Nov 17 19:08:35 [1442788.933] {Default Queue} wl_data_offer#4278190080.offer("text/plain;charset=utf-8")
Nov 17 19:08:35 [1442788.934] {Default Queue} wl_data_device#14.selection(wl_data_offer#4278190080)
Nov 17 19:08:35 [1442788.935] {Default Queue}  -> wl_data_offer#4278190083.destroy()
Nov 17 19:08:35 [1442788.937] {Default Queue} zwp_primary_selection_device_v1#15.data_offer(new id zwp_primary_selection_offer_v1#4278190081)
Nov 17 19:08:35 [1442788.938] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("text/plain")
Nov 17 19:08:35 [1442788.939] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("text/plain;charset=utf-8")
Nov 17 19:08:35 [1442788.940] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("STRING")
Nov 17 19:08:35 [1442788.940] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("text/plain")
Nov 17 19:08:35 [1442788.941] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("TEXT")
Nov 17 19:08:35 [1442788.942] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("COMPOUND_TEXT")
Nov 17 19:08:35 [1442788.942] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("UTF8_STRING")
Nov 17 19:08:35 [1442788.943] {Default Queue} zwp_primary_selection_offer_v1#4278190081.offer("text/plain;charset=utf-8")
Nov 17 19:08:35 [1442788.944] {Default Queue} zwp_primary_selection_device_v1#15.selection(zwp_primary_selection_offer_v1#4278190081)
Nov 17 19:08:35 [1442788.945] {Default Queue}  -> zwp_primary_selection_offer_v1#4278190082.destroy()
Nov 17 19:08:35 [1442788.947] {Default Queue} zwp_text_input_v3#3.enter(wl_surface#25)
Nov 17 19:08:35 [1442788.949] {Default Queue}  -> zwp_text_input_v3#3.enable()
Nov 17 19:08:35 [1442788.950] {Default Queue}  -> zwp_text_input_v3#3.set_content_type(0, 13)
Nov 17 19:08:35 [1442788.951] {Default Queue}  -> zwp_text_input_v3#3.commit()
Nov 17 19:08:35 [1442788.987] {mesa egl surface queue} wl_buffer#32.release()
Nov 17 19:08:35 [1442788.988] {mesa egl surface queue} wl_callback#43.done(4696)
Nov 17 19:08:35 [1442789.120] {mesa egl surface queue}  -> wl_surface#25.attach(wl_buffer#32, 0, 0)
Nov 17 19:08:35 [1442789.122] {mesa egl surface queue}  -> wl_surface#25.damage(0, 0, 2147483647, 2147483647)
Nov 17 19:08:35 [1442789.124] {mesa egl surface queue}  -> wl_surface#25.commit()
Nov 17 19:08:35 [1442789.125] {mesa egl surface queue}  -> wl_display#1.sync(new id wl_callback#43)
Nov 17 19:08:35 [1442789.129] {Default Queue}  -> wl_surface#25.frame(new id wl_callback#100)
Nov 17 19:08:35 [1442789.130] {Default Queue}  -> wl_surface#25.commit()
Nov 17 19:08:35 [1442789.136] {Default Queue} zwp_text_input_v3#3.done(26)
Nov 17 19:08:35 [1442789.169] {Display Queue} wl_display#1.delete_id(43)
Nov 17 19:08:35 [1442796.904] {Display Queue} wl_display#1.delete_id(100)
Nov 17 19:08:35 [1442796.914] {Default Queue} wl_callback#100.done(64518657)
Nov 17 19:08:35 [1442948.065] {Default Queue} wl_pointer#23.button(4699, 64518642, 272, 0)
Nov 17 19:08:35 [1442948.081] {Default Queue}  -> xdg_toplevel#30.move(wl_seat#13, 4699)
Nov 17 19:08:35 [1442948.086] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:35 [1442948.089] {Default Queue} xdg_wm_base#10.ping(64518740)
Nov 17 19:08:35 [1442948.091] {Default Queue}  -> xdg_wm_base#10.pong(64518740)
Nov 17 19:08:35 [1442948.093] {Default Queue} wl_pointer#23.button(4700, 64518740, 272, 1)
Nov 17 19:08:35 [1442948.096] {Default Queue}  -> xdg_toplevel#30.set_maximized()
Nov 17 19:08:35 [1442948.099] {Default Queue} wl_pointer#23.frame()
Nov 17 19:08:35 [1442952.111] {Default Queue} xdg_toplevel#30.configure_bounds(1648, 982)
Nov 17 19:08:35 [1442952.124] {Default Queue} xdg_toplevel#30.configure(1648, 982, array[24])
Nov 17 19:08:35 [1442952.128] {Default Queue} xdg_surface#29.configure(425)
Nov 17 19:08:35 [1442952.134] {Default Queue}  -> xdg_surface#29.ack_configure(425)
...

kitty_wayland.log

Environment details

kitty 0.37.0 created by Kovid Goyal
Linux xiaoxin 6.12.0-rc7-1-mainline #1 SMP PREEMPT_DYNAMIC Mon, 11 Nov 2024 03:59:47 +0000 x86_64
Arch Linux 6.12.0-rc7-1-mainline (/dev/tty)

Running under: Wayland (GNOME Shell 47.0) missing: layer_shell
OpenGL: '4.6 (Core Profile) Mesa 24.2.7-arch1.1' Detected version: 4.6
Frozen: False
Fonts:
  medium: NotoSansMono-Regular: /usr/share/fonts/noto/NotoSansMono-Regular.ttf:0
          Features: ()
    bold: NotoSansMono-Bold: /usr/share/fonts/noto/NotoSansMono-Bold.ttf:0
          Features: ()
  italic: NotoSansMono-Regular: /usr/share/fonts/noto/NotoSansMono-Regular.ttf:0
          Features: ()
      bi: NotoSansMono-Bold: /usr/share/fonts/noto/NotoSansMono-Bold.ttf:0
          Features: ()
Paths:
  kitty: /usr/bin/kitty
  base dir: /usr/lib/kitty
  extensions dir: /usr/lib/kitty/kitty
  system shell: /usr/bin/bash
Loaded config files:
  /home/user/.config/kitty/kitty.conf

Config options different from defaults:
cursor_blink_interval (0.0, kitty.options.utils.EasingFunction(), kitty.options.utils.EasingFunction())

Important environment variables seen by the kitty process:
	PATH                                /usr/local/bin:/usr/bin:/usr/local/sbin:/var/lib/flatpak/exports/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/usr/lib/rustup/bin
	LANG                                en_US.UTF-8
	SHELL                               /usr/bin/bash
	DISPLAY                             :0
	WAYLAND_DISPLAY                     wayland-0
	USER                                user
	LC_MEASUREMENT                      en_GB.UTF-8
	LC_MONETARY                         en_GB.UTF-8
	LC_NUMERIC                          en_GB.UTF-8
	LC_PAPER                            en_GB.UTF-8
	LC_TIME                             en_GB.UTF-8
	XDG_DATA_DIRS                       /home/user/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share/:/usr/share/
	XDG_RUNTIME_DIR                     /run/user/1000
	LC_ADDRESS                          en_GB.UTF-8
	LC_TELEPHONE                        en_GB.UTF-8
	XDG_CURRENT_DESKTOP                 GNOME
	XDG_MENU_PREFIX                     gnome-
	XDG_SESSION_CLASS                   user
	XDG_SESSION_DESKTOP                 gnome
	XDG_SESSION_TYPE                    wayland

[kovidgoyal]

kitty has no code to handle touchpad events. It
relies on the compositor to convert those to pointer button events and a
double click is detected on windows decorations purely based on time
since last click, so whether the pointer moves in between is irrelevant.
The following one line patch shows that the compositor is converting a
double tap into a press and release event rather than press and press
event. In my testing I found tapping more firmly causes the compositor
to send the expected press and press events. Probably some tap detection
threshold you need to adjust in the compositor.

diff --git a/glfw/wl_client_side_decorations.c b/glfw/wl_client_side_decorations.c
index 6690c5b4dc..0a32fdb35b 100644
--- a/glfw/wl_client_side_decorations.c
+++ b/glfw/wl_client_side_decorations.c
@@ -795,6 +795,7 @@ static void
 handle_pointer_button(_GLFWwindow *window, uint32_t button, uint32_t state) {
     uint32_t edges = XDG_TOPLEVEL_RESIZE_EDGE_NONE;
     if (button == BTN_LEFT) {
+        printf("11111111 is_on_titlebar: %d state_is_pressed: %d\n", decs.focus == CSD_titlebar, state == WL_POINTER_BUTTON_STATE_PRESSED);
         switch (decs.focus) {
             case CENTRAL_WINDOW: break;
             case CSD_titlebar:

[darkblaze69]

Thanks for quick response.

libinput doesn't show significant delay between events

 event9   GESTURE_HOLD_BEGIN      +4.186s	1
 event9   GESTURE_HOLD_END        +4.201s	1
 event9   GESTURE_HOLD_BEGIN      +6.196s	1
 event9   GESTURE_HOLD_END        +6.203s	1
 event9   GESTURE_HOLD_BEGIN      +8.136s	1
 event9   GESTURE_HOLD_END        +8.143s	1
 event9   GESTURE_HOLD_BEGIN      +11.652s	1
 event9   GESTURE_HOLD_END        +11.659s	1
 event9   GESTURE_HOLD_BEGIN      +14.711s	1
 event9   GESTURE_HOLD_END        +14.739s	1

There's the discussion on this issue with mutter devs, they say it's up to clients. If you think something wrong in mutter, here's the discussion:

https://gitlab.gnome.org/GNOME/mutter/-/issues/2669

fwiw alacritty was able to make corrections to resolve this similar issue:

alacritty/alacritty#7011

[kovidgoyal]

Sigh, GNOME. This is clearly a GNOME bug. They should not be swallowing
a press event if the previous press event triggers a move, unless the
move results in the cursor going out of bounds. It does not here.

But, whatever, I dont have the patience to argue with them. Since the
whole CSD code section exists only for GNOME I'll just workaround their
bug when I have a minute. The kitty changelog is already full of
workarounds just for them.