Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for direction of windows (left_window, right_window, up_window, down_window) #916

Closed
esn89 opened this issue Sep 7, 2018 · 10 comments

Comments

@esn89
Copy link

esn89 commented Sep 7, 2018

Hi I was wondering if this support currently exists, or is something in the roadmap.
Coming from years of vim and other vim like tools, I have a habit with kitty_mod + {h,j,k,l} to select the window relative to where I am at.

Is there any way of doing so?

@kovidgoyal
Copy link
Owner

It's not in the roadmap, but it is pretty trivial to implement, I might get to it someday. Personally, I would prefer a visual selector. Press a key see numbers/letters overlaid over the windows and pick the one you want.

In the meantime, patches are welcome, if you wish to work on this and you need guidance, feel free to ask, I will be happy to help.

@esn89
Copy link
Author

esn89 commented Sep 7, 2018

Thanks for the quick reply.

For starters, which file should I start looking into for examples if I were to make a PR?

@kovidgoyal
Copy link
Owner

Just grep the code for next_window you would need to implement similar functions for left_window, right_window, etc

@esn89
Copy link
Author

esn89 commented Sep 7, 2018

and to build the app/view my changes, it is simply: make app? and then run the binary that results?

@kovidgoyal
Copy link
Owner

@kovidgoyal kovidgoyal reopened this Sep 8, 2018
@esn89
Copy link
Author

esn89 commented Sep 8, 2018

Thank you so much @kovidgoyal , you are the best!

@kovidgoyal
Copy link
Owner

you're welcome :)

@strix
Copy link
Contributor

strix commented Sep 8, 2018

This is awesome! Any way you’ll extend this functionality to movement as well?

@kovidgoyal
Copy link
Owner

Sure cb36713

@strix
Copy link
Contributor

strix commented Sep 8, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants