Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wayland key repeat frequency #1055

Merged
merged 1 commit into from Oct 9, 2018

Conversation

tarmack
Copy link
Contributor

@tarmack tarmack commented Oct 9, 2018

The Wayland protocol specification uses a Hz value in the key repeat rate field. The code however uses this value as a millisecond interval. This pull request makes the code calculate the interval from the Hz value.

This should probably be upstreamed to glfw but I'm not entirely sure how to go about that since the code seems to have seen quite a few changes there (but looks like it still does the wrong thing here).

@kovidgoyal
Copy link
Owner

kitty's copy of glfw has diverged from upstream, so if you want to send it upstream, it would probably be a different patch.

@kovidgoyal kovidgoyal merged commit c494759 into kovidgoyal:master Oct 9, 2018
@tarmack
Copy link
Contributor Author

tarmack commented Oct 9, 2018

I noticed that the code has diverged, will you be syncing with upstream again at some point in the near future? Because If you do not, I don't really care to go and test with upstream glfw I suppose. And if you will sync I may just go about fixing it then I suppose.

@kovidgoyal
Copy link
Owner

No the divergence is permanent for many reasons, principally glfw/glfw#1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants