Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack layout: Add align_top_left option #1670

Merged
merged 1 commit into from Jun 3, 2019
Merged

Conversation

copy
Copy link
Contributor

@copy copy commented Jun 2, 2019

Fixes #505.

Needs some documentation, but I'll wait for a review first.

@kovidgoyal
Copy link
Owner

I dont think this makes sense as a layout option. Why should it be available only for the stack layout? If you do want to make it per layout, then the there should be a global setting, overridable, per layout.

@copy
Copy link
Contributor Author

copy commented Jun 2, 2019

You're right, I hadn't considered that layouts may be switched. I've moved it to a global option.

@kovidgoyal kovidgoyal merged commit 961ff86 into kovidgoyal:master Jun 3, 2019
@blunckr
Copy link

blunckr commented Sep 26, 2019

I'm confused, do I just add align_top_left yes to my kitty.conf. I've done that and it seems to have no effect. I'm running 0.14.4, which has this code in it.

@copy
Copy link
Contributor Author

copy commented Sep 27, 2019

@blunckr The option was later renamed to placement_strategy.

@blunckr
Copy link

blunckr commented Sep 27, 2019

That works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertically align content to top instead of center
3 participants