Fix triangle glyphs scaling by drawing them manually

[bew]

Fixes #2006

🎉 🎉 🎉
Thanks for the help @kovidgoyal

---

I updated the testing functions to use the new format of the class setup_for_testing (was probably a function before, now it uses a with ...: syntax).

I also changed something in icat, because the testing functions for box drawing make use of the method show from icat, which previously gave an error saying that screen_size is None at this line:

kitty/kittens/icat/main.py

Line 125 in 26b7b1e

ss = screen_size()

(which is called from show)

[kovidgoyal]

Please resolve the conflicts then I will merge.

[bew]

The builds fail because there is a trailing whitespace somewhere... I'm not on my computer right now, so It's pretty hard for me to find it (github UI is not helpful), could you take a quick look?

As a sidenote, it would be nice to see where the trailing whitespace is in the CI
nevermind I'm blind

[bew]

Note: I didn't test this last change on glyph ids as I'm not on my computer right now, will do later today if you don't

[bew]

I get a test failure now:

FAIL: test_box_drawing (kitty_tests.fonts.Rendering)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/project/kitty/launcher/../../kitty_tests/fonts.py", line 55, in test_box_drawing
    self.assertEqual(len(self.sprites), prerendered + len(box_chars))
    line = '─━│┃╌╍┄┅┈┉╎╏┆┇┊┋╴╵╶╷╸╹╺╻╼╽╾╿\ue0b0\ue0b2\ue0b4\ue0b6\ue0b1\ue0b3\ue0b8\ue0ba\ue0bc\ue0be═║╞╡╥╨╪╫╬╠╣╦╩╱╲╳▀▁▂▃▄▅▆▇█▉▊▋▌▍▎▏▐░▒▓▔▕▖▗▘▙▚▛▜▝▞▟┌┍┎┏┐┑┒┓└┕┖┗┘┙┚┛╭╮╯╰┼┽┾┿╀╁╂╃╄╅╆╇╈╉╊╋├┝┞┟┠┡┢┣┤┥┦┧┨┩┪┫┬┭┮┯┰┱┲┳┴┵┶┷┸┹┺┻╒╕╘╛╓╖╙╜╔╗╚╝╟╢╤╧'
    prerendered = 9
    s = <fast_data_types.Screen object at 0x564484aad320>
    self = <kitty_tests.fonts.Rendering testMethod=test_box_drawing>
AssertionError: 178 != 179

I'm not sure what to do here..

[Luflosi]

Is there an advantage in using

with setup_for_testing(family, sz) as (_, width, height):

instead of just

(_, width, height) = setup_for_testing(family, sz)

?

[bew]

Well, setup_for_testing is actually a class now, not a function (and the previous code hasn't been updated when the change happened, and simply didn't work):

kitty/kitty/fonts/render.py

Line 222 in 7d8edcc

class setup_for_testing:

This syntax with the with ... as ... : and an indented block will do some operation before entering the block (the __enter__ method of the returned obj), then do some more thing at the end of the block (the __exit__ method).

[Luflosi]

Thanks for the explanation.