macOS: Allow hiding the titlebar only instead of all window decorations #2286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this yet, I haven't written the documentation yet, I just wanted to get some feedback first.
This commit un-deprecates the
macos_hide_titlebar
config option and implements it how it was supposed to function in the first place.Thanks to @ntruong for writing ntruong@cb8279e and ntruong@6807411, the code was very helpful.
Is it ok to un-deprecate this config option and change what it does?
Is it ok to call
cocoa_hide_window_title()
incocoa_hide_titlebar()
or does that cause any problems with theautoreleasepool
blocks?hide_window_decorations yes
:macos_hide_titlebar yes
: