Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Allow hiding the titlebar only instead of all window decorations #2286

Merged
merged 1 commit into from Jan 15, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jan 15, 2020

Don't merge this yet, I haven't written the documentation yet, I just wanted to get some feedback first.

This commit un-deprecates the macos_hide_titlebar config option and implements it how it was supposed to function in the first place.

Thanks to @ntruong for writing ntruong@cb8279e and ntruong@6807411, the code was very helpful.

Is it ok to un-deprecate this config option and change what it does?
Is it ok to call cocoa_hide_window_title() in cocoa_hide_titlebar() or does that cause any problems with the autoreleasepool blocks?

hide_window_decorations yes:
hide_window_decorations

macos_hide_titlebar yes:
macos_hide_titlebar

@kovidgoyal
Copy link
Owner

Rather than undeprecate the option make hide_window_decorations take a titlebar-only keyword. It should be fine as far as I know autorelease pools can be arbitrarily nested.

@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 15, 2020

But this only works on macOS, which is why I think it is not a good idea to use hide_window_decorations for this.

@kovidgoyal
Copy link
Owner

That option already has a disclaimer saying actual effects are OS/window
manager dependant. Simply add to that disclaimer saying titlebar-only
works only on macOS.

@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 15, 2020

Like this? Keep in mind that I still did not change the documentation yet.

@kovidgoyal
Copy link
Owner

Looks fine.

@Luflosi Luflosi changed the title macOS: Properly implement the macos_hide_titlebar option macOS: Allow hiding the titlebar only instead of all window decorations Jan 15, 2020
@Luflosi Luflosi marked this pull request as ready for review January 15, 2020 15:36
@Luflosi
Copy link
Contributor Author

Luflosi commented Jan 15, 2020

Please review.

@kovidgoyal kovidgoyal merged commit ea1ef70 into kovidgoyal:master Jan 15, 2020
@Luflosi Luflosi deleted the macos_hide_titlebar branch January 15, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants