Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_ltr #2293

Merged
merged 2 commits into from Jan 18, 2020
Merged

Add force_ltr #2293

merged 2 commits into from Jan 18, 2020

Conversation

ctrlcctrlv
Copy link
Sponsor Contributor

Close #2252.

This allows users to forcibly disable RTL; since Kitty doesn't support BIDI anyway, this makes selecting RTL substrings more tolerable, but many users may prefer the current behavior, so it's off by default.

@kovidgoyal called this a "bandaid", and I understand why, but I hope he merges it because I find it useful, and I know that @hseg will too

2020-01-17-161718_2398x1185_scrot

2020-01-17-162116_2883x1732_scrot

@hseg
Copy link

hseg commented Jan 17, 2020 via email

@ctrlcctrlv
Copy link
Sponsor Contributor Author

I agree. I come into contact with Hebrew text surprisingly frequently, as I make fonts and some of my build scripts and tests include Hebrew text. So I need to be able to select Hebrew substrings, which is basically impossible with the current way things work.

I hope this will get merged even though Kovid closed your issue. It can always be taken out if full BIDI support is added, and it's optional

@kovidgoyal
Copy link
Owner

I said I dont want to spend the time on it, I have no objections to
someone else spending the time. Will review the PR when I have a moment.

@ctrlcctrlv
Copy link
Sponsor Contributor Author

ctrlcctrlv commented Jan 17, 2020

The push I just made was a documentation-only change. I realized that this commit is much more useful than I originally thought—it allows GNU FriBidi to work with Kitty!

2020-01-17-180041_3147x1732_scrot
2020-01-17-180830_2868x1732_scrot

This was completely unintentional, but very useful!

Add above fact to documentation.
@kovidgoyal kovidgoyal merged commit 5a2cc45 into kovidgoyal:master Jan 18, 2020
ahmedelgabri added a commit to ahmedelgabri/dotfiles that referenced this pull request Jan 28, 2020
Kitty doesn't support RTL & the author mentioned a couple of times that
he has no plans to do so, what a bummer. But in 0.16.0 he added this
hack/workaround to force rendering always as LTR which weirdly enough
improved the RTL support at least became tolerable kovidgoyal/kitty#2293 (comment)

More context:

kovidgoyal/kitty#2293
kovidgoyal/kitty#2252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Disabling bidi support
3 participants