Add support for sending mouse events from a kitten #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovidgoyal
reviewed
Apr 12, 2020
| if (!PyArg_ParseTuple(args, "O!IIiii", &Screen_Type, &screen, &x, &y, &button, &action, &mods)) return NULL; | ||
|
|
||
| MouseTrackingMode mode = screen->modes.mouse_tracking_mode; | ||
| if (mode == ANY_MODE || (mode == MOTION_MODE && action != MOVE) || (mode == BUTTON_MODE && (action == PRESS || action == RELEASE))) { |
There was a problem hiding this comment.
Shouldnt this be action == move??
There was a problem hiding this comment.
No, when the mode is MOTION_MODE, the terminal should send PRESS, RELEASE and DRAG actions, but not MOVE actions.
There was a problem hiding this comment.
I could write mode == MOTION_MODE && (action == PRESS || action == RELEASE || action == DRAG) if that's clearer?
It would be nice with some tests for this function, but not sure how to test the whole function? I guess the easiest would be to pull out this if to a separate function and test that?
This allows you to a control a program running in kitty from a kitten using mouse events. If the program is not receiving mouse events of that type, it is not sent.
trygveaa
force-pushed
the
kitten-send-mouse-events
branch
from
84303c2
to
43af6e3
Compare
|
That force push was just fixing some indentation I had messed up. |
|
On Sun, Apr 12, 2020 at 07:13:19AM -0700, Trygve Aaberge wrote:
@trygveaa commented on this pull request.
> @@ -698,6 +700,25 @@ scroll_event(double UNUSED xoffset, double yoffset, int flags) {
}
}
+static PyObject*
+send_mouse_event(PyObject *self UNUSED, PyObject *args) {
+ Screen *screen;
+ unsigned int x, y;
+ int button, action, mods;
+ if (!PyArg_ParseTuple(args, "O!IIiii", &Screen_Type, &screen, &x, &y, &button, &action, &mods)) return NULL;
+
+ MouseTrackingMode mode = screen->modes.mouse_tracking_mode;
+ if (mode == ANY_MODE || (mode == MOTION_MODE && action != MOVE) || (mode == BUTTON_MODE && (action == PRESS || action == RELEASE))) {
I could write `mode == MOTION_MODE && (action == PRESS || action == RELEASE || action == DRAG)` if that's clearer?
No, it's fine.
It would be nice with some tests for this function, but not sure how to test the whole function? I guess the easiest would be to pull out this if to a separate function and test that?
You can test the whole function by getting the output sent by
write_escape_code_to_child. Which can be done by passing test_child
to the Screen object.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to a control a program running in kitty from a kitten
using mouse events. If the program is not receiving mouse events of that
type, it is not sent.