Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed marks grouping and coloring for simultaneous multi marks definition #2663

Merged
merged 1 commit into from May 18, 2020

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented May 18, 2020

This PR fixes an issue with multiple simultaneous mark groups defined. The issue exists on a latest Kitty version and on top of the master branch. If I try to define several marks simultaneously in any available approach I got a text colored just by one color and that color just corresponds to a first mark group in the making definition.

Steps to reproduce:

  1. echo -e 'WARN\nERROR\nFAIL'
  2. kitty @ create-marker regex 1 FAIL 2 ERR 3 WARN

All three words should have different colors but all of them just colored as the FAIL word by the color of the first group in the applied marking definition.

Bellow screenshots demonstrate the issue:
Screenshot from 2020-05-18 06-52-20
Screenshot from 2020-05-18 06-51-21

With the PR fix:
Screenshot from 2020-05-18 07-08-22

P.S: And thanks for the great project! 馃殌

@kovidgoyal kovidgoyal merged commit 09fbd6f into kovidgoyal:master May 18, 2020
@ahlinc
Copy link
Contributor Author

ahlinc commented May 18, 2020

Super fast merge 馃殌 馃樅 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants