Fix upwards selection not being cleared when lines change #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting text by dragging upwards, the "end" of the selection is above the "start". This causes the `selection_has_screen_line()` to never return `true` in this case. In practice this bug causes the selection to not be cleared when the screen contents under the selection change if it was made by dragging upwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting text by dragging upwards, the "end" of the selection is above the "start". This causes the
selection_has_screen_line()to never returntruein this case.In practice this bug causes the selection to not be cleared when the screen contents under the selection change if it was made by dragging upwards.
Please double-check that
s->start_scrolled_byands->end_scrolled_bydon't need to be subtracted fromtopandbottominstead as I'm not sure.