Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: fix spotlight search in help menu not working on some machines #3567

Merged

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented May 3, 2021

The spotlight search in the "Help" menu of the menu bar did not appear when the system language is set to a language other than English. macOS magically adds the search box when the text in that menu matches the translation of "Help" in the system language. On my German system for example replacing "Help" with "Hilfe" will make the search box appear again. This is however not a good solution for kitty as it would require implementing localization support for all languages. Removing CFBundleAllowMixedLocalizations=True from setup.py also brings back the search box but that may break the locale again. The line was added in 8818b5d to fix an issue related to #1233.
Luckily I found a seemingly undocumented function that helps us out here, which does not rely the text comparison magic.

The spotlight search in the "Help" menu of the menu bar did not appear when the system language is set to a language other than English. macOS magically adds the search box when the text in that menu matches the translation of "Help" in the system language. On my German system for example replacing "Help" with "Hilfe" will make the search box appear again. This is however not a good solution for kitty as it would require implementing localization support for all languages. Removing `CFBundleAllowMixedLocalizations=True` from `setup.py` also brings back the search box but that may break the locale again. The line was added in  8818b5d to fix an issue related to kovidgoyal#1233.
Luckily I found a seemingly undocumented function that helps us out here, which does not rely the text comparison magic.
@kovidgoyal kovidgoyal merged commit 49459b3 into kovidgoyal:master May 4, 2021
@Luflosi Luflosi deleted the fix-help-menu-spotlight-search branch May 4, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants