Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option adjust_baseline to adjust the baseline position on macOS #3734

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

ytang
Copy link
Contributor

@ytang ytang commented Jun 15, 2021

Add option adjust_baseline to adjust the baseline position on macOS

Fixes #3728

@kovidgoyal
Copy link
Owner

Some issues:

  1. It needs to have a way to specify different units, just like adjust_line_height
  2. It needs to work on linux as well look in freetype.c
  3. You cant adjust only the baseline you have to adjust the underline position and strikethrough position as well

@ytang
Copy link
Contributor Author

ytang commented Jun 16, 2021

Some issues:

  1. It needs to have a way to specify different units, just like adjust_line_height

Done. Now it takes either a number of pixels or a percentage of the line height.

  1. It needs to work on linux as well look in freetype.c

Done.

  1. You cant adjust only the baseline you have to adjust the underline position and strikethrough position as well

The underline and strikethrough positions are adjusted accordingly.

PTAL.

@kovidgoyal kovidgoyal merged commit 5d0eb1d into kovidgoyal:master Jun 16, 2021
@ytang ytang mentioned this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: adjust_line_height cuts off text since commit 39b3d3d
2 participants