Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibus's dbus name owner changed detection #4059

Merged
merged 2 commits into from Sep 26, 2021
Merged

Conversation

unisgn
Copy link
Contributor

@unisgn unisgn commented Sep 24, 2021

fcitx5 works fine with kitty, except that when you restart fcitx5, kitty stop working with fcitx5, because the dbus_connection_get_is_connected(ibus->conn) in #check_connection is always true when you use fcitx5.
this patch add a dbus name owner changed detection to detect the online status of ibus, in case the ibus backend uses the session bus, like fcitx5.

fcitx5 works fine with kitty, except that when you restart fcitx5, kitty stop working with fcitx5, because the dbus_connection_get_is_connected(ibus->conn) in #check_connection is always true when you use fcitx5.
this patch add a dbus name owner changed detection to detect the online status of ibus, in case the ibus backend uses the session bus, like fcitx5.
@unisgn
Copy link
Contributor Author

unisgn commented Sep 24, 2021

@wengxt 有空请帮忙审查一下这个提交呢。之前在 fcitx5 上提交了 issue#272,,这个提交就是为了解决那个问题的,帮忙看看有没有问题呢。

@kovidgoyal kovidgoyal merged commit b05e939 into kovidgoyal:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants