Add a separate color option for visuall bell#4181
Add a separate color option for visuall bell#4181kovidgoyal merged 3 commits intokovidgoyal:masterfrom
Conversation
|
Looks generally fine. Only concern is that is OSC 20 actually meant for this? I can find no reference for this. For instance the xterm ctlseqs page only mentions osc 19 and then 22. If there is some reference please let me know otherwise leave out the bits that set these colors in tui/operations.py and window.py as its possible OSC 20 is used for something else. |
|
Also i made the list of color keys in collection.py generated by gen-config.py as well. |
1abf77d to
b4a6ed8
Compare
As far as I know OSC 20 is not used, I removed the relevant code. It looks like there is no escape sequence for visual bell color at the moment.
Thanks, I have updated it according to this. |
|
There is one remaining issue. The selection bg color can itself be set |
|
Fixed, now falls back to default foreground color when selection background color is none. Please check if it is appropriate. |
Provide independent color configuration option for visual bell, instead of only reusing the highlighted selection background color.
Because visuall bell renders in full window, users can choose to use less glaring dark colors.
It also allows theme customization and remote control.
Here is a custom alert bell effect with alternating red and blue colors.
In addition, I added
# generated by gen-config.py DO NOT editto kitty/rc/set_colors.pynullable_colors.Please check if it is appropriate and if there are any omissions, thank you.