Fix searching the last command output

[page-down]

When searching the output of the last command executed, if scrollback has been scrolled,
then the start point is actually outside (below) the screen and the number of scrolled lines needs to be added.

That's my bad. I don't know how this was slipped through. :(

Please review, thank you.

[page-down]

In a previous change to fix mark duplication, some code was removed.
But today I tested it and found that the output continued is occurring.
I'll try to add it back to see if it fixes the related issue.

2cc3922

[page-down]

After I added the code back in, I could get the command output normally after resizing the window.

I did not submit this part yet. Maybe need to look at the previous fix first.

I found that the prompt mark appears to be copied.

c43637f

[page-down]

Not really, it has nothing to do with the previous fix.

I pushed a new commit and checked the continued attribute.
Currently getting the output normal after resizing the window.

Please let me know if there is anything missed.

[kovidgoyal]

I wont be able to review this till tomorrow, however I think you should consider adding some tests for it as this is relatively easily testable and fairly complex. See the test_prompt_marking() function

[page-down]

Sure, I'll add more tests.
I've always thought kitty's test cases could be covered a bit more.
Apart from system integration (especially macOS), isn't it possible to cover a bit more range? How would it be more appropriate to contribute?

[kovidgoyal]

You are welcome to send PRs with more tests, if you need help getting
started, just ask.