macOS: Fix the mouse cursor being set to arrow after switching desktops#4716
Merged
Conversation
macOS will set the cursor to arrow after milliseconds after the switch desktop animation ends. So the cursor that was updated immediately after the focus will be changed again. This also affects toggling fullscreen.
Contributor
Author
|
This error log still appears (rarely), and I have no idea where this event is coming from. And I can't find the steps that are reproducible. (ctrl+cmd+f ...) |
Owner
|
If the error causes no actual bad effects, I dont think its worth bothering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS will set the cursor to arrow after milliseconds after the switch
desktop animation ends.
So the cursor that was updated immediately after the focus will be changed again.
This also affects toggling fullscreen.
Reduce unnecessary cursor updates since we don't use cursor rects.
Please review, thank you.