Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Fix the mouse cursor being set to arrow after switching desktops #4716

Merged
merged 3 commits into from
Feb 19, 2022

Conversation

page-down
Copy link
Contributor

macOS will set the cursor to arrow after milliseconds after the switch
desktop animation ends.
So the cursor that was updated immediately after the focus will be changed again.
This also affects toggling fullscreen.

Reduce unnecessary cursor updates since we don't use cursor rects.

Please review, thank you.

macOS will set the cursor to arrow after milliseconds after the switch
desktop animation ends. So the cursor that was updated immediately after
the focus will be changed again. This also affects toggling fullscreen.
@kovidgoyal kovidgoyal merged commit 702bb2c into kovidgoyal:master Feb 19, 2022
@page-down page-down deleted the fix-macos-cur-update branch February 19, 2022 04:12
@page-down
Copy link
Contributor Author

This error log still appears (rarely), and I have no idea where this event is coming from.

And I can't find the steps that are reproducible. (ctrl+cmd+f ...)

kitty[4110:173498] Bad cursor rect event, flags = 1376265
frame #1: 0x00007ff821b21f58 AppKit`-[NSApplication(NSCursorRects) _handleCursorRectEvent:] + 318
frame #2: 0x00007ff8217376cf AppKit`-[NSApplication(NSEvent) sendEvent:] + 3335
frame #3: 0x00007ff8219f01a7 AppKit`-[NSApplication _handleEvent:] + 65
frame #4: 0x00007ff8215b793e AppKit`-[NSApplication run] + 623
frame #5: 0x0000000105a748ba glfw-cocoa.so`glfwRunMainLoop + 90

@kovidgoyal
Copy link
Owner

If the error causes no actual bad effects, I dont think its worth bothering
about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants