Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste from finder files / folder selection is to show full path #5142

Closed
wants to merge 1 commit into from

Conversation

jameshuynh
Copy link

Description

Kitty does not have the capability to capture the full path of files & folders when a user press Cmd+C on finder and paste, i.e. Kitty only can paste the file name or folder name. On Iterm or Mac terminal, it can paste the escape full path.

This PR is to let Kitty have the same capability as Iterm or Mac terminal where the full path will be pasted instead of just the file name or folder name

@kovidgoyal
Copy link
Owner

  1. You should use https://developer.apple.com/documentation/foundation/nsurl/1412925-filesystemrepresentation?language=objc to convert urls to file system paths.

  2. You are freeing _glfw.ns.clipboardString but its not guaranteed you are setting it to something else. It should only be freed if being set. Or if you are freeing it, then set it to null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants