Add "user" tab to themes kitten #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hard coded tab string and replace with self.tabs, which is a reference to the same tab string defined in the __init__ of ThemesHandler
Add new tab named "user" to the built-in themes kitten - new tab filters and displays only user-defined color themes, identified by adding "is_user_defined" property to "Theme" class which defaults to False, and is set True when a theme is fetched using the "load_from_dir" method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add new tab named "user" to the built-in themes kitten - new tab filters and displays only user-defined color themes, and ignores all themes defined in the kitty-themes repository (https://github.com/kovidgoyal/kitty-themes)
Useful for:
Remarks