Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable resizing in session files. #5196

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

sirno
Copy link
Contributor

@sirno sirno commented Jun 14, 2022

This PR enables resizing windows in session files.

It is a bit of a hack because semantically I overload the window list in the session object.

Feel free to request changes.

@kovidgoyal
Copy link
Owner

I'd prefer it if the resize command was stored alongwith the window
launch spec in the windows list. You can have the windows list contain a
new class that stores the launch spec and the resize spec.

@sirno
Copy link
Contributor Author

sirno commented Jun 14, 2022

Yes that is indeed much clearer.

I adjusted the code to do this, however currently it will crash when resize_window is called before a window is launched. do you think there should be an error message for such a case?

@kovidgoyal
Copy link
Owner

Something provided before the first window should apply to the first window. That's how all the rest of the settings work, IIRC.

@kovidgoyal kovidgoyal merged commit 1d846f3 into kovidgoyal:master Jun 14, 2022
@sirno sirno deleted the session-resize-window branch June 14, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants